Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flag indicator in profile save example #598

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

ryuash
Copy link
Contributor

@ryuash ryuash commented Sep 2, 2021

Description

closes #597

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #598 (213efcd) into master (16e1eeb) will increase coverage by 9.27%.
The diff coverage is 77.98%.

❗ Current head 213efcd differs from pull request most recent head a90599c. Consider uploading reports for the commit a90599c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
+ Coverage   75.59%   84.86%   +9.27%     
==========================================
  Files          94       91       -3     
  Lines        4519     5384     +865     
==========================================
+ Hits         3416     4569    +1153     
+ Misses        960      605     -355     
- Partials      143      210      +67     
Impacted Files Coverage Δ
x/commons/commons.go 100.00% <ø> (ø)
x/profiles/keeper/msg_server_app_link.go 0.00% <ø> (ø)
x/profiles/keeper/msg_server_blocks.go 100.00% <ø> (ø)
x/profiles/keeper/msg_server_chain_link.go 100.00% <ø> (ø)
x/profiles/keeper/msg_server_dtag_transfers.go 74.75% <ø> (-1.72%) ⬇️
x/profiles/keeper/msg_server_relationships.go 100.00% <ø> (ø)
x/profiles/keeper/msgs_server_profile.go 82.22% <ø> (+5.47%) ⬆️
x/profiles/keeper/relay_app_links.go 95.38% <ø> (ø)
x/profiles/keeper/relay_chain_links.go 87.09% <ø> (+0.43%) ⬆️
x/profiles/simulation/decoder.go 63.15% <ø> (-28.85%) ⬇️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 831823e...a90599c. Read the comment docs.

@ryuash ryuash marked this pull request as ready for review September 2, 2021 03:56
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM merged commit b40144b into master Sep 2, 2021
@RiccardoM RiccardoM deleted the ryuash/fix-profile-save-cli-example branch September 2, 2021 06:02
@RiccardoM RiccardoM changed the title add: flag indicator in example fix: flag indicator in example Sep 2, 2021
@RiccardoM RiccardoM changed the title fix: flag indicator in example fix: flag indicator in profile save example Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CLI profile save example
2 participants