feat: ADR-009: Make MsgSaveProfile DTag optional

x/profiles/client/cli/cli_profile.go

@@ -13,31 +13,31 @@ import (
  "github.com/desmos-labs/desmos/v2/x/profiles/types"
 )
 
-// GetCmdSaveProfile returns the command used to save a profile
 func GetCmdSaveProfile() *cobra.Command {
  cmd := &cobra.Command{
- Use: "save [dtag]",
- Args: cobra.ExactArgs(1),
- Short: "Save your profile associating to it the given DTag.",
+ Use: "save",
+ Args: cobra.NoArgs,
+ Short: "Save your profile",
  Long: fmt.Sprintf(`
-Save a new profile or edit the existing one specifying a DTag, a nickname, biography, profile picture and cover picture.
-Every data given through the flags is optional.
-If you are editing an existing profile you should fill only the fields that you want to edit.
-The empty ones will be filled with a special [do-not-modify] flag that tells the system to not edit them.
-
-%s tx profiles save LeoDiCap \
- --%s "Leonardo Di Caprio" \
- --%s "Hollywood actor. Proud environmentalist" \
- --%s "https://profilePic.jpg" \
- --%s "https://profileCover.jpg"
-`, version.AppName, FlagNickname, FlagBio, FlagProfilePic, FlagCoverPic),
+ Save a new profile or edit the existing one specifying a DTag, a nickname, biography, profile picture and cover picture.
+ Every data given through the flags is optional.
+ If you are editing an existing profile you should fill only the fields that you want to edit.
+ The empty ones will be filled with a special [do-not-modify] flag that tells the system to not edit them.
+
+ %s tx profiles save 
+ --%s "LeoDiCaprio" \
+ --%s "Leonardo Di Caprio" \
+ --%s "Hollywood actor. Proud environmentalist" \
+ --%s "https://profilePic.jpg" \
+ --%s "https://profileCover.jpg"
+ `, version.AppName, FlagDTag, FlagNickname, FlagBio, FlagProfilePic, FlagCoverPic),
  RunE: func(cmd *cobra.Command, args []string) error {
  clientCtx, err := client.GetClientTxContext(cmd)
  if err != nil {
  return err
  }
 
- dTag := args[0]
+ dTag, _ := cmd.Flags().GetString(FlagDTag)
  nickname, _ := cmd.Flags().GetString(FlagNickname)
  bio, _ := cmd.Flags().GetString(FlagBio)
  profilePic, _ := cmd.Flags().GetString(FlagProfilePic)
@@ -52,6 +52,7 @@ The empty ones will be filled with a special [do-not-modify] flag that tells the
  },
  }
 
+ cmd.Flags().String(FlagDTag, types.DoNotModify, "DTag to be used")
  cmd.Flags().String(FlagNickname, types.DoNotModify, "Nickname to be used")
  cmd.Flags().String(FlagBio, types.DoNotModify, "Biography to be used")
  cmd.Flags().String(FlagProfilePic, types.DoNotModify, "Profile picture")

x/profiles/client/cli/cli_profile_test.go

@@ -115,7 +115,7 @@ func (s *IntegrationTestSuite) TestCmdSaveProfile() {
  {
  name: "correct data returns no error",
  args: []string{
- "dtag",
+ fmt.Sprintf("--%s=%s", cli.FlagDTag, "dtag"),
  fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()),
  fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
  fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastBlock),

x/profiles/client/cli/keys.go

@@ -1,6 +1,7 @@
 package cli
 
 const (
+ FlagDTag = "dtag"
  FlagNickname = "nickname"
  FlagBio = "bio"
  FlagProfilePic = "profile-pic"

x/profiles/keeper/msgs_server_profile_test.go

@@ -94,7 +94,7 @@ func (suite *KeeperTestSuite) TestMsgServer_SaveProfile() {
  name: "profile saved with same DTag but capital first letter (with previous profile created)",
  store: func(ctx sdk.Context) {
  profile := suite.CheckProfileNoError(types.NewProfile(
- "tc",
+ "tomtom",
  "old-nickname",
  "old-biography",
  types.NewPictures(
@@ -134,7 +134,7 @@ func (suite *KeeperTestSuite) TestMsgServer_SaveProfile() {
  name: "profile not saved because of the same DTag",
  store: func(ctx sdk.Context) {
  profile := suite.CheckProfileNoError(types.NewProfile(
- "tc",
+ "Test",
  "nickname",
  "biography",
  types.NewPictures(
@@ -156,6 +156,58 @@ func (suite *KeeperTestSuite) TestMsgServer_SaveProfile() {
  ),
  shouldErr: true,
  },
+ {
+ name: "profile not saved because DTag is set to DoNotModify",
+ msg: types.NewMsgSaveProfile(
+ types.DoNotModify,
+ "another-one",
+ "biography",
+ "https://tc.com/profile-pic",
+ "https://tc.com/cover-pic",
+ "cosmos1cjf97gpzwmaf30pzvaargfgr884mpp5ak8f7ns",
+ ),
+ shouldErr: true,
+ },
+ {
+ name: "profile updated correctly with DTag set to DoNotModify",
+ store: func(ctx sdk.Context) {
+ profile := suite.CheckProfileNoError(types.NewProfile(
+ "tomtom",
+ "nickname",
+ "biography",
+ types.NewPictures(
+ "https://tc.com/profile-pic",
+ "https://tc.com/cover-pic",
+ ),
+ blockTime,
+ testutil.AccountFromAddr("cosmos1cjf97gpzwmaf30pzvaargfgr884mpp5ak8f7ns"),
+ ))
+ suite.Require().NoError(suite.k.StoreProfile(ctx, profile))
+ },
+ msg: types.NewMsgSaveProfile(
+ types.DoNotModify,
+ "another-one",
+ "biography",
+ "https://tc.com/profile-pic",
+ "https://tc.com/cover-pic",
+ "cosmos1cjf97gpzwmaf30pzvaargfgr884mpp5ak8f7ns",
+ ),
+ expEvents: sdk.Events{
+ sdk.NewEvent(
+ types.EventTypeProfileSaved,
+ sdk.NewAttribute(types.AttributeProfileDTag, "tomtom"),
+ sdk.NewAttribute(types.AttributeProfileCreator, "cosmos1cjf97gpzwmaf30pzvaargfgr884mpp5ak8f7ns"),
+ sdk.NewAttribute(types.AttributeProfileCreationTime, blockTime.Format(time.RFC3339)),
+ ),
+ },
+ check: func(ctx sdk.Context) {
+ profile, found, err := suite.k.GetProfile(ctx, "cosmos1cjf97gpzwmaf30pzvaargfgr884mpp5ak8f7ns")
+ suite.Require().NoError(err)
+ suite.Require().True(found)
+ suite.Require().Equal("tomtom", profile.DTag)
+ suite.Require().Equal("another-one", profile.Nickname)
+ },
+ },
  {
  name: "profile not edited because of the invalid profile picture",
  store: func(ctx sdk.Context) {

x/profiles/types/account_test.go

@@ -176,6 +176,21 @@ func TestProfile_Validate(t *testing.T) {
  )),
  shouldErr: true,
  },
+ {
+ name: "setting DTag to DoNotModify returns error",
+ account: testutil.AssertNoProfileError(types.NewProfile(
+ types.DoNotModify,
+ "",
+ "bio",
+ types.NewPictures(
+ "https://shorturl.at/adnX3",
+ "https://shorturl.at/cgpyF",
+ ),
+ time.Now(),
+ testutil.AccountFromAddr("cosmos1y54exmx84cqtasvjnskf9f63djuuj68p7hqf47"),
+ )),
+ shouldErr: true,
+ },
  {
  name: "invalid profile picture returns error",
  account: testutil.AssertNoProfileError(types.NewProfile(

x/profiles/types/msgs_profile.go

@@ -2,7 +2,6 @@ package types
 
 import (
  "fmt"
- "strings"
 
  sdk "github.com/cosmos/cosmos-sdk/types"
  sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
@@ -37,10 +36,6 @@ func (msg MsgSaveProfile) ValidateBasic() error {
  return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, fmt.Sprintf("invalid creator: %s", msg.Creator))
  }
 
- if strings.TrimSpace(msg.DTag) == "" {
- return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "profile dtag cannot be empty or blank")
- }
-
  return nil
 }
 

x/profiles/types/msgs_profile_test.go

@@ -45,18 +45,6 @@ func TestMsgSaveProfile_ValidateBasic(t *testing.T) {
  ),
  shouldErr: true,
  },
- {
- name: "empty DTag returns error",
- msg: types.NewMsgSaveProfile(
- "",
- "",
- "",
- "",
- "",
- "cosmos1cjf97gpzwmaf30pzvaargfgr884mpp5ak8f7ns",
- ),
- shouldErr: true,
- },
  {
  name: "valid message returns no error",
  msg: msgEditProfile,

x/profiles/types/query_app_links.go

@@ -1,7 +1,7 @@
 package types
 
 import (
- query "github.com/cosmos/cosmos-sdk/types/query"
+ "github.com/cosmos/cosmos-sdk/types/query"
 )
 
 // NewQueryApplicationLinksRequest returns a new QueryApplicationLinksRequest instance