Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ADR-010: Mutual DTag exchange between users. #656

Merged
merged 7 commits into from
Oct 20, 2021

Conversation

leobragaz
Copy link
Contributor

@leobragaz leobragaz commented Oct 19, 2021

Description

This PR implements the changes approved in ADR 010.
Closes: #643


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

when the receiver accept the request and specifies the sender dtag
removed some tests from adr referred to the old adr implementation proposal
@github-actions github-actions bot added kind/adr An issue or PR relating to an architectural decision record x/CLI x/profiles Module that allows to create and manage decentralized social profiles labels Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #656 (bc9ea35) into master (1a22342) will decrease coverage by 68.53%.
The diff coverage is 55.10%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #656       +/-   ##
===========================================
- Coverage   84.23%   15.70%   -68.54%     
===========================================
  Files          91      168       +77     
  Lines        6624    45954    +39330     
===========================================
+ Hits         5580     7218     +1638     
- Misses        833    38119    +37286     
- Partials      211      617      +406     
Impacted Files Coverage Δ
x/profiles/client/cli/cli_app_links.go 34.16% <ø> (ø)
x/profiles/client/cli/cli_params.go 70.00% <ø> (ø)
x/profiles/client/cli/cli_relationships.go 75.51% <ø> (ø)
x/profiles/client/cli/query.go 0.00% <ø> (ø)
x/profiles/client/cli/tx.go 0.00% <ø> (ø)
x/profiles/client/utils/cli.pb.go 3.12% <ø> (ø)
x/profiles/client/utils/utils.go 56.25% <ø> (ø)
x/profiles/keeper/alias_functions.go 90.47% <ø> (ø)
x/profiles/keeper/genesis.go 84.61% <ø> (ø)
x/profiles/keeper/grpc_query.go 73.78% <ø> (ø)
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cb3ac...bc9ea35. Read the comment docs.

Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

added a check in swap dtags testcase
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Oct 20, 2021
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM

@mergify mergify bot merged commit 71960c8 into master Oct 20, 2021
@mergify mergify bot deleted the leonardo/adr-010-impl branch October 20, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/adr An issue or PR relating to an architectural decision record x/CLI x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to mutually exchange DTags
3 participants