chore: release v2.1.0-testnet #657

RiccardoM · 2021-10-20T12:28:54Z

Description

This PR implements the changes needed in order to tag v2.1.0-testnet of Desmos.

Due to the current Desmos status being different in the testnet and mainnet, we will need two versions for v2.1.0:

v2.1.0-testnet will be used inside the testnet
v2.1.0-mainnet will be used inside the mainnet

The changes will be identical, we will only have two different upgrade handlers due to the fact that Morpheus has already undergone an on-chain upgrade while the mainnet has not.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…release/v2.1.0-testnet

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

RiccardoM · 2021-10-20T12:29:19Z

.github/workflows/on-chain-upgrade.yml

+ GENESIS_DESMOS_VERSION: "v2.0.0"
+ GENESIS_URL: "https://raw.githubusercontent.com/RiccardoM/desmos-states/master/morpheus-apollo-2-2500000.json"
+ UPGRADE_NAME: "v2.1.0"


These are just to make sure the upgrade goes properly when running it inside the CI.

RiccardoM · 2021-10-20T12:30:06Z

app/app.go

-
- return app.mm.RunMigrations(ctx, app.configurator, fromVM)
+ app.upgradeKeeper.SetUpgradeHandler("v2.1.0", func(ctx sdk.Context, plan upgradetypes.Plan, vm module.VersionMap) (module.VersionMap, error) {
+ app.IBCKeeper.ConnectionKeeper.SetParams(ctx, ibcconnectiontypes.DefaultParams())


Since we forgot to add this line inside the latest Morpheus upgrade, we need to do this now. Ref: cosmos/cosmos-sdk#10398 (comment)

RiccardoM · 2021-10-20T12:30:54Z

app/app.go

- return app.mm.RunMigrations(ctx, app.configurator, fromVM)
+ app.upgradeKeeper.SetUpgradeHandler("v2.1.0", func(ctx sdk.Context, plan upgradetypes.Plan, vm module.VersionMap) (module.VersionMap, error) {
+ app.IBCKeeper.ConnectionKeeper.SetParams(ctx, ibcconnectiontypes.DefaultParams())
+ return app.mm.RunMigrations(ctx, app.configurator, vm)


Since the testnet has already undergone an upgrade, we need to pass the provided vm here instead of creating a custom one

RiccardoM · 2021-10-20T12:31:06Z

app/app.go

- Added: []string{authz.ModuleName, feegrant.ModuleName},
- }
+ if upgradeInfo.Name == "v2.1.0" && !app.upgradeKeeper.IsSkipHeight(upgradeInfo.Height) {
+ storeUpgrades := storetypes.StoreUpgrades{}


We will not have any store upgrade this version for the testnet

RiccardoM · 2021-10-20T12:31:40Z

contrib/upgrade_testnet/setup_genesis.py

@@ -59,6 +59,7 @@

 chain_state['app_state']['slashing'] = genesis['app_state']['slashing']

+ chain_state['app_state']['gov']['deposit_params']['max_deposit_period'] = '120s'


This is to make sure that all upgrade proposals have a decent deposit period during the CI runs

RiccardoM · 2021-10-20T12:32:03Z

contrib/upgrade_testnet/submit_upgrade_proposal.sh

@@ -63,7 +63,7 @@ sleep 6s

 echo ""
 echo "===> Getting proposal id"
-PROPOSAL_ID=$(desmos q tx $TX_HASH --output json 2>&1 | jq .logs[0].events[2].attributes[0].value -r)
+PROPOSAL_ID=$(desmos q tx $TX_HASH --output json 2>&1 | jq .logs[0].events[4].attributes[0].value -r)


Cosmos changed the positions of the attributes. Now the proposal ID can be found inside the 5th event instead of the 3rd one

codecov · 2021-10-20T12:34:12Z

Codecov Report

Merging #657 (2b64f06) into master (71960c8) will increase coverage by 0.08%.
The diff coverage is 70.76%.

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
+ Coverage   15.70%   15.79%   +0.08%     
==========================================
  Files         168      169       +1     
  Lines       45954    45990      +36     
==========================================
+ Hits         7218     7264      +46     
+ Misses      38119    38105      -14     
- Partials      617      621       +4

Impacted Files	Coverage Δ
app/app.go	`82.23% <0.00%> (+4.53%)`	⬆️
x/profiles/keeper/migrations.go	`55.55% <0.00%> (-15.88%)`	⬇️
x/profiles/types/models_app_links.pb.go	`0.61% <ø> (ø)`
x/profiles/types/models_chain_links.pb.go	`33.81% <ø> (ø)`
x/profiles/legacy/v210/store.go	`79.31% <79.31%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71960c8...2b64f06. Read the comment docs.

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

dadamu

🚀

leobragaz · 2021-10-20T15:50:15Z

x/profiles/legacy/v210/store.go

+
+ return nil
+}
+


@RiccardoM I guess these two functions below are tested with the on chain upgrade action right?
If so, this is ready to go 👍

@bragaz I forgot to add a test, you're right. Will do asap

@bragaz Thanks for the heads up about the test 🙏 While implementing it I actually discovered a bug inside the migration process. It should be fixed and ready to go now hopefully

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

RiccardoM · 2021-10-21T06:33:06Z

contrib/images/desmos-cosmovisor/Dockerfile

@@ -1,5 +1,5 @@
 ARG DESMOS_VERSION="v0.17.2"
-FROM golang:1.15-alpine AS build-env
+FROM golang:1.17-alpine AS build-env


This is now required by Cosmovisor to build properly

RiccardoM · 2021-10-21T06:37:38Z

x/profiles/legacy/v200/store.go

@@ -41,6 +41,7 @@ func migrateAppLinks(store sdk.KVStore, cdc codec.BinaryCodec) error {
 iterator := sdk.KVStorePrefixIterator(store, types.UserApplicationLinkPrefix)
 defer iterator.Close()

+ var keys [][]byte


I've changed this to make sure we do not incur in any possible bug when re-computing the keys. This is just a precaution I added after I discovered I was computing the links keys wrongly inside v2.1.0

leobragaz

Ready to go 🚀

## Description This PR implements the changes needed in order to tag `v2.1.0-mainnet` of Desmos. Refer to #657 for major details. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

RiccardoM added 9 commits October 19, 2021 08:29

Set v2.1.0 upgrade handler

63a67f2

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added the migrations for the x/profile module

f3139ff

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Fixed migrations for testnet

24862e2

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Updated on-chain upgrade test

3681afe

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added missing connection param setting

cba83ae

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

improved x/profiles consensus version handling

621310d

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

b312d7b

…release/v2.1.0-testnet

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

2a6ef91

…release/v2.1.0-testnet

Version 2.1.0

c20205a

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

RiccardoM added the requires-upgrade Test the on-chain upgrade for this PR label Oct 20, 2021

github-actions bot added kind/ci Improve the CI/CD x/profiles Module that allows to create and manage decentralized social profiles labels Oct 20, 2021

RiccardoM commented Oct 20, 2021

View reviewed changes

RiccardoM requested review from leobragaz and dadamu October 20, 2021 12:32

RiccardoM added 3 commits October 20, 2021 14:49

Version 2.1.0

b715093

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Version 2.1.0

8b8eb6b

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Version 2.1.0

f2e0042

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

dadamu approved these changes Oct 20, 2021

View reviewed changes

leobragaz reviewed Oct 20, 2021

View reviewed changes

RiccardoM added 2 commits October 20, 2021 20:44

improved how the migration is performed and added tests

bb1f9ea

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

fix: improved the migration for v2.0.0

32fb3b8

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

RiccardoM requested a review from leobragaz October 20, 2021 18:53

RiccardoM changed the title ~~build: version v2.1.0-testnet~~ chore: release v2.1.0-testnet Oct 20, 2021

RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Oct 21, 2021

RiccardoM added 2 commits October 21, 2021 08:31

updated Proto comments to specify the encodings where necessary

29257f9

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

updated deps versions inside Makefile

2b64f06

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

github-actions bot added the kind/build Related to the build of the project label Oct 21, 2021

RiccardoM commented Oct 21, 2021

View reviewed changes

leobragaz approved these changes Oct 21, 2021

View reviewed changes

mergify bot merged commit 17a5bff into master Oct 21, 2021

mergify bot deleted the riccardo/release/v2.1.0-testnet branch October 21, 2021 06:45

RiccardoM mentioned this pull request Oct 26, 2021

chore: release v2.3.0-mainnet #660

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: release v2.1.0-testnet #657

chore: release v2.1.0-testnet #657

RiccardoM commented Oct 20, 2021 •

edited by leobragaz

Loading

RiccardoM Oct 20, 2021

RiccardoM Oct 20, 2021

RiccardoM Oct 20, 2021

RiccardoM Oct 20, 2021

RiccardoM Oct 20, 2021

RiccardoM Oct 20, 2021 •

edited

Loading

codecov bot commented Oct 20, 2021 •

edited

Loading

dadamu left a comment

leobragaz Oct 20, 2021

RiccardoM Oct 20, 2021

RiccardoM Oct 20, 2021

RiccardoM Oct 21, 2021

RiccardoM Oct 21, 2021

leobragaz left a comment

		@@ -59,6 +59,7 @@

		chain_state['app_state']['slashing'] = genesis['app_state']['slashing']

		chain_state['app_state']['gov']['deposit_params']['max_deposit_period'] = '120s'

chore: release v2.1.0-testnet #657

chore: release v2.1.0-testnet #657

Conversation

RiccardoM commented Oct 20, 2021 • edited by leobragaz Loading

Description

Author Checklist

Reviewers Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RiccardoM Oct 20, 2021 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Oct 20, 2021 • edited Loading

Codecov Report

dadamu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leobragaz left a comment

Choose a reason for hiding this comment

RiccardoM commented Oct 20, 2021 •

edited by leobragaz

Loading

RiccardoM Oct 20, 2021 •

edited

Loading

codecov bot commented Oct 20, 2021 •

edited

Loading