feat: add support for hex address in chain link

.changeset/entries/6b0bd955ce8e24b2b9fdf0923da002de55a8cf4fab6e91fddd7dcc4c1854efab.yaml

@@ -0,0 +1,6 @@
+type: feat
+module: x/profiles
+pull_request: 688
+description: add support for hex address in chain link
+backward_compatible: true
+date: 2021-12-10T03:38:53.1017055Z

go.mod

@@ -4,23 +4,23 @@ go 1.15
 
 require (
  github.com/armon/go-metrics v0.3.10
+ github.com/btcsuite/btcd v0.22.0-beta
  github.com/cosmos/cosmos-sdk v0.44.5
  github.com/cosmos/go-bip39 v1.0.0
  github.com/cosmos/ibc-go v1.2.5
+ github.com/ethereum/go-ethereum v1.10.13
  github.com/ghodss/yaml v1.0.0
  github.com/gogo/protobuf v1.3.3
  github.com/golang/protobuf v1.5.2
  github.com/gorilla/mux v1.8.0
  github.com/grpc-ecosystem/grpc-gateway v1.16.0
- github.com/hashicorp/golang-lru v0.5.5-0.20210104140557-80c98217689d // indirect
  github.com/manifoldco/promptui v0.9.0
  github.com/mr-tron/base58 v1.2.0
  github.com/rakyll/statik v0.1.7
  github.com/regen-network/cosmos-proto v0.3.1
  github.com/spf13/cast v1.4.1
  github.com/spf13/cobra v1.3.0
  github.com/stretchr/testify v1.7.0
- github.com/syndtr/goleveldb v1.0.1-0.20210305035536-64b5b1c73954 // indirect
  github.com/tendermint/tendermint v0.34.15
  github.com/tendermint/tm-db v0.6.6
  google.golang.org/genproto v0.0.0-20211208223120-3a66f561d7aa

proto/desmos/profiles/v1beta1/models_chain_links.proto

@@ -93,4 +93,19 @@ message Base58Address {
 
  // Value contains the Base58-encoded address
  string value = 1 [ (gogoproto.moretags) = "yaml:\"value\"" ];
+}
+
+// HexAddress represents an Hex-encoded address
+// NOTE: Currently it only supports keccak256-uncompressed addresses
+message HexAddress {
+ option (gogoproto.goproto_getters) = false;
+ option (gogoproto.equal) = true;
+ option (gogoproto.goproto_stringer) = true;
+ option (cosmos_proto.implements_interface) = "AddressData";
+
+ // Value represents the hex address value
+ string value = 1 [ (gogoproto.moretags) = "yaml:\"value\"" ];
+
+ // Prefix represents the optional prefix used during address encoding (e.g. 0x)
+ string prefix = 2 [ (gogoproto.moretags) = "yaml:\"prefix\"" ];
 }

x/profiles/types/codec.go

@@ -29,6 +29,7 @@ func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
  cdc.RegisterInterface((*AddressData)(nil), nil)
  cdc.RegisterConcrete(&Bech32Address{}, "desmos/Bech32Address", nil)
  cdc.RegisterConcrete(&Base58Address{}, "desmos/Base58Address", nil)
+ cdc.RegisterConcrete(&HexAddress{}, "desmos/HexAddress", nil)
 
  cdc.RegisterConcrete(&Profile{}, "desmos/Profile", nil)
 }
@@ -42,6 +43,7 @@ func RegisterInterfaces(registry types.InterfaceRegistry) {
  (*AddressData)(nil),
  &Bech32Address{},
  &Base58Address{},
+ &HexAddress{},
  )
 
  registry.RegisterImplementations((*sdk.Msg)(nil),

x/profiles/types/models_chain_links.go

@@ -10,6 +10,8 @@ import (
  "github.com/cosmos/cosmos-sdk/types/bech32"
  "github.com/tendermint/tendermint/crypto/tmhash"
 
+ "github.com/btcsuite/btcd/btcec"
+ "github.com/ethereum/go-ethereum/crypto"
  "github.com/gogo/protobuf/proto"
  "github.com/mr-tron/base58"
 
@@ -202,6 +204,56 @@ func (b Base58Address) VerifyPubKey(key cryptotypes.PubKey) (bool, error) {
 
 // --------------------------------------------------------------------------------------------------------------------
 
+var _ AddressData = &HexAddress{}
+
+// NewHexAddress returns a new HexAddress instance
+func NewHexAddress(value, prefix string) *HexAddress {
+ return &HexAddress{Value: value, Prefix: prefix}
+}
+
+// Validate implements AddressData
+func (h HexAddress) Validate() error {
+ if strings.TrimSpace(h.Value) == "" {
+ return fmt.Errorf("value cannot be empty or blank")
+ }
+
+ if len(h.Value) <= len(h.Prefix) {
+ return fmt.Errorf("address cannot be smaller than prefix")
+ }
+
+ prefix, addrWithoutPrefix := h.Value[:len(h.Prefix)], h.Value[len(h.Prefix):]
+ if prefix != h.Prefix {
+ return fmt.Errorf("prefix does not match")
+ }
+
+ if _, err := hex.DecodeString(addrWithoutPrefix); err != nil {
+ return fmt.Errorf("invalid hex address")
+ }
+ return nil
+}
+
+// GetValue implements AddressData
+func (h HexAddress) GetValue() string {
+ return h.Value
+}
+
+// VerifyPubKey implements AddressData
+func (h HexAddress) VerifyPubKey(key cryptotypes.PubKey) (bool, error) {
+ addr := h.Value[len(h.Prefix):]
+ bz, err := hex.DecodeString(addr)
+ if err != nil {
+ return false, err
+ }
+ pubKey, err := btcec.ParsePubKey(key.Bytes(), btcec.S256())
+ if err != nil {
+ return false, err
+ }
+ uncompressedPubKey := pubKey.SerializeUncompressed()
+ return bytes.Equal(crypto.Keccak256(uncompressedPubKey[1:])[12:], bz), err
+}
+
+// --------------------------------------------------------------------------------------------------------------------
+
 // UnpackAddressData deserializes the given any type value as an address data using the provided unpacker
 func UnpackAddressData(unpacker codectypes.AnyUnpacker, addressAny *codectypes.Any) (AddressData, error) {
  var address AddressData