feat: ADR-005: Support multisig chain link

.changeset/entries/a492eff6c4ec45c98cb555b14de9f27ba50da5b147ff05b7a4cb1707af73655c.yaml

@@ -0,0 +1,6 @@
+type: feat
+module: x/profiles
+pull_request: 708
+description: Support multisig chain link
+backward_compatible: false
+date: 2022-01-12T03:49:42.2638125Z

Makefile

@@ -349,6 +349,12 @@ proto-update-deps:
  @mkdir -p $(IBC_TYPES)/core/client/v1
  @curl -sSL $(IBC_URL)/core/client/v1/client.proto > $(IBC_TYPES)/core/client/v1/client.proto
 
+ @mkdir -p $(COSMOS_TYPES)/tx/signing/v1beta1
+ @curl -sSL $(COSMOS_URL)/tx/signing/v1beta1/signing.proto > $(COSMOS_TYPES)/tx/signing/v1beta1/signing.proto
+
+ @mkdir -p $(COSMOS_TYPES)/crypto/multisig/v1beta1
+ @curl -sSL $(COSMOS_URL)/crypto/multisig/v1beta1/multisig.proto > $(COSMOS_TYPES)/crypto/multisig/v1beta1/multisig.proto
+
 ## Importing of tendermint protobuf definitions currently requires the
 ## use of `sed` in order to build properly with cosmos-sdk's proto file layout
 ## (which is the standard Buf.build FILE_LAYOUT)

app/desmos/cmd/chainlink/create_json.go

@@ -7,9 +7,14 @@ import (
 
  chainlinktypes "github.com/desmos-labs/desmos/v2/app/desmos/cmd/chainlink/types"
 
+ "github.com/cosmos/cosmos-sdk/client"
+ "github.com/cosmos/cosmos-sdk/client/tx"
  "github.com/cosmos/cosmos-sdk/crypto/hd"
  "github.com/cosmos/cosmos-sdk/crypto/keyring"
  sdk "github.com/cosmos/cosmos-sdk/types"
+ "github.com/cosmos/cosmos-sdk/types/tx/signing"
+ authclient "github.com/cosmos/cosmos-sdk/x/auth/client"
+ authsigning "github.com/cosmos/cosmos-sdk/x/auth/signing"
  "github.com/spf13/cobra"
 
  "github.com/desmos-labs/desmos/v2/app"
@@ -31,8 +36,8 @@ desmos tx profiles link-chain [/path/to/json/file.json]
 Note that this command will ask you the mnemonic that should be used to generate the private key of the address you want to link.
 The mnemonic is only used temporarily and never stored anywhere.`,
  RunE: func(cmd *cobra.Command, args []string) error {
- // Get the data
- mnemonic, err := getter.GetMnemonic()
+
+ isSingleSignatureAccount, err := getter.IsSingleSignatureAccount()
  if err != nil {
  return err
  }
@@ -42,15 +47,37 @@ The mnemonic is only used temporarily and never stored anywhere.`,
  return err
  }
 
- filename, err := getter.GetFilename()
- if err != nil {
- return err
- }
+ var chainLinkJSON profilescliutils.ChainLinkJSON
+ if isSingleSignatureAccount {
+ // Get the data
+ mnemonic, err := getter.GetMnemonic()
+ if err != nil {
+ return err
+ }
 
- // Build che chain link JSON
- chainLinkJSON, err := generateChainLinkJSON(mnemonic, chain)
- if err != nil {
- return err
+ // Build che chain link JSON
+ chainLinkJSON, err = generateChainLinkJSON(mnemonic, chain)
+ if err != nil {
+ return err
+ }
+ } else {
+ multiSignedTxFile, err := getter.GetMultiSignedTxFile()
+ if err != nil {
+ return err
+ }
+ signedChainID, err := getter.GetSignedChainID()
+ if err != nil {
+ return err
+ }
+ txCfg, txBuilder, txFactory, err := getMultisignedTxReference(cmd, multiSignedTxFile, signedChainID)
+ if err != nil {
+ return err
+ }
+
+ chainLinkJSON, err = getChainLinkJSONFromMultiSign(txCfg, txBuilder, txFactory, chain)
+ if err != nil {
+ return err
+ }
  }
 
  cdc, _ := app.MakeCodecs()
@@ -59,6 +86,10 @@ The mnemonic is only used temporarily and never stored anywhere.`,
  return err
  }
 
+ filename, err := getter.GetFilename()
+ if err != nil {
+ return err
+ }
  if filename != "" {
  err = ioutil.WriteFile(filename, bz, 0600)
  if err != nil {
@@ -73,7 +104,7 @@ The mnemonic is only used temporarily and never stored anywhere.`,
  }
 }
 
-// generateChainLinkJSON returns build a new ChainLinkJSON intance using the provided mnemonic and chain configuration
+// generateChainLinkJSON build a new ChainLinkJSON instance using the provided mnemonic and chain configuration
 func generateChainLinkJSON(mnemonic string, chain chainlinktypes.Chain) (profilescliutils.ChainLinkJSON, error) {
  // Create an in-memory keybase for signing
  keyBase := keyring.NewInMemory()
@@ -91,10 +122,80 @@ func generateChainLinkJSON(mnemonic string, chain chainlinktypes.Chain) (profile
  if err != nil {
  return profilescliutils.ChainLinkJSON{}, err
  }
+ sigData := &profilestypes.SingleSignatureData{
+ Mode: signing.SignMode_SIGN_MODE_DIRECT,
+ Signature: sig,
+ }
 
  return profilescliutils.NewChainLinkJSON(
  profilestypes.NewBech32Address(addr, chain.Prefix),
- profilestypes.NewProof(pubkey, hex.EncodeToString(sig), hex.EncodeToString(value)),
+ profilestypes.NewProof(pubkey, sigData, hex.EncodeToString(value)),
  profilestypes.NewChainConfig(chain.Name),
  ), nil
 }
+
+// getMultisignedTxReference returns the multisigned tx reference to build the chain link json
+func getMultisignedTxReference(
+ cmd *cobra.Command,
+ txFile string,
+ signedChainID string,
+) (client.TxConfig, client.TxBuilder, tx.Factory, error) {
+ clientCtx, err := client.GetClientTxContext(cmd)
+ if err != nil {
+ return nil, nil, tx.Factory{}, err
+ }
+ parsedTx, err := authclient.ReadTxFromFile(clientCtx, txFile)
+ if err != nil {
+ return nil, nil, tx.Factory{}, err
+ }
+ txCfg := clientCtx.TxConfig
+ txBuilder, err := txCfg.WrapTxBuilder(parsedTx)
+ if err != nil {
+ return nil, txBuilder, tx.Factory{}, err
+ }
+ txFactory := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithChainID(signedChainID)
+ if txFactory.SignMode() == signing.SignMode_SIGN_MODE_UNSPECIFIED {
+ txFactory = txFactory.WithSignMode(signing.SignMode_SIGN_MODE_LEGACY_AMINO_JSON)
+ }
+ return txCfg, txBuilder, txFactory, err
+}
+
+// getChainLinkJSONFromMultiSign generates the chain-link JSON from the multisign tx reference
+func getChainLinkJSONFromMultiSign(
+ txCfg client.TxConfig,
+ txBuilder client.TxBuilder,
+ txFactory tx.Factory,
+ chain chainlinktypes.Chain,
+) (profilescliutils.ChainLinkJSON, error) {
+ sigs, err := txBuilder.GetTx().GetSignaturesV2()
+ if err != nil {
+ return profilescliutils.ChainLinkJSON{}, err
+ }
+ // make sure there is only one signature for the multisig account
+ if len(sigs) != 1 {
+ return profilescliutils.ChainLinkJSON{}, fmt.Errorf("invalid number of signatures")
+ }
+ multisigSig := sigs[0]
+ signingData := authsigning.SignerData{
+ ChainID: txFactory.ChainID(),
+ AccountNumber: txFactory.AccountNumber(),
+ Sequence: txFactory.Sequence(),
+ }
+ // the bytes of plain text
+ value, err := txCfg.SignModeHandler().GetSignBytes(txFactory.SignMode(), signingData, txBuilder.GetTx())
+ if err != nil {
+ return profilescliutils.ChainLinkJSON{}, err
+ }
+
+ addr, err := sdk.Bech32ifyAddressBytes(chain.Prefix, multisigSig.PubKey.Address().Bytes())
+ if err != nil {
+ return profilescliutils.ChainLinkJSON{}, err
+ }
+
+ sigData, err := profilestypes.SignatureDataFromCosmosSignatureData(multisigSig.Data)
+ return profilescliutils.NewChainLinkJSON(
+ profilestypes.NewBech32Address(addr, chain.Prefix),
+ profilestypes.NewProof(multisigSig.PubKey, sigData, hex.EncodeToString(value)),
+ profilestypes.NewChainConfig(chain.Name),
+ ), err
+}