Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ADR-006: Subspaces module #728

Merged
merged 49 commits into from
Feb 16, 2022
Merged

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jan 24, 2022

Description

This PR implements ADR-006: Subspaces module adding a new x/subspaces module.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…subspace-module-adr-impl

� Conflicts:
�	x/profiles/types/models_chain_links.pb.go
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@github-actions github-actions bot added x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module labels Jan 24, 2022
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #728 (6c6e53b) into master (e387353) will increase coverage by 1.89%.
The diff coverage is 83.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   78.77%   80.67%   +1.89%     
==========================================
  Files          53       69      +16     
  Lines        4387     6054    +1667     
==========================================
+ Hits         3456     4884    +1428     
- Misses        749      930     +181     
- Partials      182      240      +58     
Impacted Files Coverage Δ
x/subspaces/types/codec.go 0.00% <0.00%> (ø)
x/subspaces/types/models.go 86.86% <ø> (ø)
x/subspaces/types/msgs.go 97.45% <ø> (ø)
x/subspaces/types/permissions.go 65.38% <ø> (ø)
x/profiles/types/genesis.go 94.73% <50.00%> (ø)
app/app.go 79.82% <52.63%> (-0.79%) ⬇️
x/profiles/legacy/v300/store.go 61.53% <61.53%> (ø)
x/profiles/client/cli/cli_relationships.go 76.04% <73.33%> (+0.53%) ⬆️
x/profiles/keeper/keeper_relationships.go 70.00% <75.00%> (+1.03%) ⬆️
x/subspaces/keeper/alias_functions.go 81.31% <81.31%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e387353...6c6e53b. Read the comment docs.

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM marked this pull request as ready for review January 26, 2022 09:26
@RiccardoM RiccardoM requested review from dadamu and leobragaz and removed request for dadamu January 26, 2022 09:26
@RiccardoM RiccardoM mentioned this pull request Jan 26, 2022
19 tasks
app/app.go Outdated Show resolved Hide resolved
proto/desmos/subspaces/v1/genesis.proto Outdated Show resolved Hide resolved
proto/desmos/subspaces/v1/genesis.proto Outdated Show resolved Hide resolved
proto/desmos/subspaces/v1/msgs.proto Outdated Show resolved Hide resolved
proto/desmos/subspaces/v1/subspace.proto Outdated Show resolved Hide resolved
x/subspaces/keeper/msg_server.go Show resolved Hide resolved
x/subspaces/types/genesis.go Outdated Show resolved Hide resolved
x/subspaces/client/cli/tx.go Show resolved Hide resolved
proto/desmos/subspaces/v1/subspace.proto Outdated Show resolved Hide resolved
x/subspaces/keeper/msg_server.go Show resolved Hide resolved
@RiccardoM RiccardoM requested review from dadamu and removed request for leobragaz February 7, 2022 08:13
x/subspaces/keeper/groups.go Outdated Show resolved Hide resolved
Co-authored-by: Paul <p22626262@gmail.com>
@RiccardoM RiccardoM requested a review from dadamu February 7, 2022 11:13
x/subspaces/types/models.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overrall is good to me. Just have minor questions as above, and the sim test is failed.

@github-actions github-actions bot added the kind/adr An issue or PR relating to an architectural decision record label Feb 10, 2022
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go🚀

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Feb 16, 2022
@mergify mergify bot merged commit 9396ce0 into master Feb 16, 2022
@mergify mergify bot deleted the riccardo/subspace-module-adr-impl branch February 16, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/adr An issue or PR relating to an architectural decision record x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants