fix: improve x/profiles gRPC queries #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…subspace-module-adr-impl � Conflicts: � x/profiles/types/models_chain_links.pb.go
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
… files Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…ps module Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…relationships-module � Conflicts: � app/app.go � app/desmos/cmd/chainlink/create_json_test.go � app/params/weights.go � client/docs/swagger-ui/swagger.yaml � proto/desmos/profiles/v1beta1/query_relationships.proto � proto/desmos/profiles/v2/models_relationships.proto � proto/desmos/profiles/v3/genesis.proto � proto/desmos/profiles/v3/msg_server.proto � proto/desmos/profiles/v3/msgs_dtag_requests.proto � proto/desmos/profiles/v3/msgs_profile.proto � proto/desmos/profiles/v3/msgs_relationships.proto � proto/desmos/profiles/v3/query.proto � proto/desmos/profiles/v3/query_relationships.proto � proto/desmos/relationships/v1/query.proto � proto/desmos/subspaces/v1/genesis.proto � proto/desmos/subspaces/v1/msgs.proto � proto/desmos/subspaces/v1/query.proto � x/profiles/client/cli/cli_test.go � x/profiles/keeper/genesis_test.go � x/profiles/keeper/grpc_query.go � x/profiles/keeper/grpc_query_test.go � x/profiles/keeper/invariants.go � x/profiles/keeper/invariants_test.go � x/profiles/keeper/keeper.go � x/profiles/keeper/migrations.go � x/profiles/keeper/msg_server_blocks.go � x/profiles/keeper/msg_server_relationships.go � x/profiles/keeper/msg_server_relationships_test.go � x/profiles/legacy/v2/models_relationships.pb.go � x/profiles/legacy/v3/store.go � x/profiles/module.go � x/profiles/simulation/decoder.go � x/profiles/simulation/decoder_test.go � x/profiles/simulation/genesis.go � x/profiles/simulation/operations.go � x/profiles/types/genesis.go � x/profiles/types/genesis.pb.go � x/profiles/types/genesis_test.go � x/profiles/types/keys.go � x/profiles/types/msg_server.pb.go � x/profiles/types/msgs_dtag_requests.pb.go � x/profiles/types/msgs_profile.pb.go � x/profiles/types/query.pb.go � x/profiles/types/query.pb.gw.go � x/relationships/client/cli/tx.go � x/relationships/keeper/blocks.go � x/relationships/keeper/blocks_test.go � x/relationships/keeper/msg_server_test.go � x/relationships/keeper/relationships.go � x/relationships/simulation/operations_relationships.go � x/relationships/types/models.go � x/relationships/types/msg_server.pb.go � x/relationships/types/msgs.go � x/relationships/types/query.pb.go � x/subspaces/client/cli/cli_test.go � x/subspaces/client/cli/query.go � x/subspaces/client/cli/tx.go � x/subspaces/handler.go � x/subspaces/keeper/alias_functions.go � x/subspaces/keeper/genesis.go � x/subspaces/keeper/genesis_test.go � x/subspaces/keeper/groups.go � x/subspaces/keeper/groups_test.go � x/subspaces/keeper/grpc_query.go � x/subspaces/keeper/grpc_query_test.go � x/subspaces/keeper/invariants.go � x/subspaces/keeper/invariants_test.go � x/subspaces/keeper/keeper.go � x/subspaces/keeper/msg_server.go � x/subspaces/keeper/msg_server_test.go � x/subspaces/keeper/permissions.go � x/subspaces/keeper/permissions_test.go � x/subspaces/keeper/subspaces.go � x/subspaces/keeper/subspaces_test.go � x/subspaces/simulation/decoder.go � x/subspaces/simulation/decoder_test.go � x/subspaces/simulation/genesis.go � x/subspaces/simulation/operations.go � x/subspaces/simulation/operations_groups.go � x/subspaces/simulation/operations_permissions.go � x/subspaces/simulation/operations_subspaces.go � x/subspaces/simulation/utils.go � x/subspaces/types/codec.go � x/subspaces/types/events.go � x/subspaces/types/genesis.go � x/subspaces/types/genesis.pb.go � x/subspaces/types/genesis_test.go � x/subspaces/types/keys.go � x/subspaces/types/msgs.go � x/subspaces/types/msgs.pb.go � x/subspaces/types/msgs_test.go � x/subspaces/types/permissions.go � x/subspaces/types/query.go � x/subspaces/types/query.pb.go � x/subspaces/types/query.pb.gw.go Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…nto riccardo/relationships-module
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…s/desmos into riccardo/fix-profiles-events
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
github-actions
bot
added
kind/build
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…s' into riccardo/improve-profiles-queries
…s/desmos into riccardo/improve-profiles-queries
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
==========================================
- Coverage 81.32% 81.20% -0.12%
==========================================
Files 77 77
Lines 6239 6248 +9
==========================================
Hits 5074 5074
- Misses 934 940 +6
- Partials 231 234 +3
Continue to review full report at Codecov.
|
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…fix-profiles-events � Conflicts: � .github/workflows/sims.yml � app/sim_test.go � x/profiles/types/events.go
…/desmos into riccardo/improve-profiles-queries
github-actions
bot
removed
x/subspaces
…improve-profiles-queries
dadamu
reviewed
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the gRPC queries for the x/profiles module by moving some parameters from the URL to the query
Closes: #757
Depends-On: #759
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change