Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ADR-009: Supply module #782
feat: ADR-009: Supply module #782
Changes from 21 commits
ada2f1b
4387c0f
3c111a7
3d84a52
aa20b9d
4461065
5817252
e996254
6750391
7a5b364
4905532
b7b9e8b
c3277cd
a3da1b8
bdbcb12
8dff037
aa292e0
b8c9dca
d93a882
30106f5
7d6735b
311e70c
3706511
ae7c345
22d52df
79278ff
0aa7c27
fd16690
30dd8da
deb9b16
0093c06
983b0c0
90f8ec4
5af8839
3ec4b0c
ea2101d
df47a9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of returning a
QueryTotalSupplyResponse
, is there any way we can simply return a string here instead? So the REST response instead of looking like thisCan simply look like this:
"<amount>"
Maybe something like StringValue from
wrappers.proto
can work like thisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, but that makes the Protobuf linter angry...any way to skip to kind of checks on query returns types? @RiccardoM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result isn't what expected btw. Should we roll-back to the previous one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering CoinMarketCap requires the supply value to be returned simply as a value, we need a way to have this as well. From their docs we can read:
Probably the best way would be to register a custom REST endpoint. This can be done using the
RegisterRESTRoutes
module method and registering a custom endpoint there.Once that's done, we can simply revert to the previous answers for the gRPC endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both done 👍