docs: add x/supply spec #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
dadamu
reviewed
Apr 25, 2022
| ``` | ||
| /supply/total/{denom} | ||
| ``` | ||
|
|
There was a problem hiding this comment.
It is missing example here, it should be like:
Example:
curl localhost:1317/supply/total/{denom}
Example Output:
1000040727987145688
dadamu
reviewed
Apr 25, 2022
|
|
||
| ``` | ||
| /supply/circulating/{denom} | ||
| ``` |
dadamu
reviewed
Apr 25, 2022
dadamu
reviewed
Apr 25, 2022
Co-authored-by: Paul <p22626262@gmail.com>
Co-authored-by: Paul <p22626262@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
dadamu
approved these changes
Apr 26, 2022
RiccardoM
added
the
docs/new
leobragaz
reviewed
May 3, 2022
x/supply/spec/02_client.md
Outdated
| ``` | ||
|
|
||
| #### total | ||
| The `total` command allows users to query the total supply of a token given a denomination. |
There was a problem hiding this comment.
Suggested change
| The `total` command allows users to query the total supply of a token given a denomination. | |
| The `total` command allows users to query the total supply of a token given a denomination and an optional divider exponent. Based on the divider exponent, the total supply is displayed differently. |
There was a problem hiding this comment.
Instead of putting this here, since the divider exponent thing is related to all queries, I've put a note right inside the Query section
| ``` | ||
|
|
||
| #### circulating | ||
| The `circulating` command allows users to query the circulating supply of a token given a denomination. |
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
leobragaz
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
specfolder inside thex/supplymodule, containing the whole specification.Depends-On: #835
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change