Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: add Amino support for x/subspaces messages #849

Merged
merged 2 commits into from
Apr 29, 2022
Merged

fix!: add Amino support for x/subspaces messages #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbdd30b
fix: add Amino support for x/subspaces messages
RiccardoM Apr 29, 2022
53504b0
added changeset entry
RiccardoM Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/entries/2ceedb22572eba8499b4b7abf8c4b38789a979fa8a852a3537dc9cba4b81bc16.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
type: fix
module: x/subspaces
pull_request: 849
description: Added correct Amino encoding support
backward_compatible: false
date: 2022-04-29T06:42:21.929594578Z
6 changes: 6 additions & 0 deletions x/subspaces/types/codec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package types
import (
"github.com/cosmos/cosmos-sdk/codec"
"github.com/cosmos/cosmos-sdk/codec/types"
cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/msgservice"
)
Expand Down Expand Up @@ -46,3 +47,8 @@ var (
// defined at the application level.
AminoCodec = codec.NewAminoCodec(amino)
)

func init() {
RegisterLegacyAminoCodec(amino)
cryptocodec.RegisterCrypto(amino)
}
18 changes: 9 additions & 9 deletions x/subspaces/types/msgs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func TestMsgCreateSubspace_ValidateBasic(t *testing.T) {
}

func TestMsgCreateSubspace_GetSignBytes(t *testing.T) {
expected := `{"creator":"cosmos1qzskhrcjnkdz2ln4yeafzsdwht8ch08j4wed69","description":"This is a test subspace","name":"Test subspace","owner":"cosmos1lv3e0l66rr68k5l74mnrv4j9kyny6cz27pvnez","treasury":"cosmos1vkuuth0rak58x36m7wuzj7ztttxh26fhqcfxm0"}`
expected := `{"type":"desmos/MsgCreateSubspace","value":{"creator":"cosmos1qzskhrcjnkdz2ln4yeafzsdwht8ch08j4wed69","description":"This is a test subspace","name":"Test subspace","owner":"cosmos1lv3e0l66rr68k5l74mnrv4j9kyny6cz27pvnez","treasury":"cosmos1vkuuth0rak58x36m7wuzj7ztttxh26fhqcfxm0"}}`
require.Equal(t, expected, string(msgCreateSubspace.GetSignBytes()))
}

Expand Down Expand Up @@ -173,7 +173,7 @@ func TestMsgEditSubspace_ValidateBasic(t *testing.T) {
}

func TestMsgEditSubspace_GetSignBytes(t *testing.T) {
expected := `{"description":"This is a new description","name":"This is a new name","owner":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1","treasury":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5"}`
expected := `{"type":"desmos/MsgEditSubspace","value":{"description":"This is a new description","name":"This is a new name","owner":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1","treasury":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5"}}`
require.Equal(t, expected, string(msgEditSubspace.GetSignBytes()))
}

Expand Down Expand Up @@ -319,7 +319,7 @@ func TestMsgCreateUserGroup_ValidateBasic(t *testing.T) {
}

func TestMsgCreateUserGroup_GetSignBytes(t *testing.T) {
expected := `{"creator":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","default_permissions":1,"description":"Description","name":"Group","subspace_id":"1"}`
expected := `{"type":"desmos/MsgCreateUserGroup","value":{"creator":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","default_permissions":1,"description":"Description","name":"Group","subspace_id":"1"}}`
require.Equal(t, expected, string(msgCreateUserGroup.GetSignBytes()))
}

Expand Down Expand Up @@ -394,7 +394,7 @@ func TestMsgEditUserGroup_ValidateBasic(t *testing.T) {
}

func TestMsgEditUserGroup_GetSignBytes(t *testing.T) {
expected := `{"description":"Description","group_id":1,"name":"Group","signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1"}`
expected := `{"type":"desmos/MsgEditUserGroup","value":{"description":"Description","group_id":1,"name":"Group","signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1"}}`
require.Equal(t, expected, string(msgEditUserGroup.GetSignBytes()))
}

Expand Down Expand Up @@ -466,7 +466,7 @@ func TestMsgSetUserGroupPermissions_ValidateBasic(t *testing.T) {
}

func TestMsgSetUserGroupPermissions_GetSignBytes(t *testing.T) {
expected := `{"group_id":1,"permissions":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1"}`
expected := `{"type":"desmos/MsgSetUserGroupPermissions","value":{"group_id":1,"permissions":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1"}}`
require.Equal(t, expected, string(msgSetUserGroupPermissions.GetSignBytes()))
}

Expand Down Expand Up @@ -544,7 +544,7 @@ func TestMsgDeleteUserGroup_ValidateBasic(t *testing.T) {
}

func TestMsgDeleteUserGroup_GetSignBytes(t *testing.T) {
expected := `{"group_id":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1"}`
expected := `{"type":"desmos/MsgDeleteUserGroup","value":{"group_id":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1"}}`
require.Equal(t, expected, string(msgDeleteUserGroup.GetSignBytes()))
}

Expand Down Expand Up @@ -636,7 +636,7 @@ func TestMsgAddUserToUserGroup_ValidateBasic(t *testing.T) {
}

func TestMsgAddUserToUserGroup_GetSignBytes(t *testing.T) {
expected := `{"group_id":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1","user":"cosmos1x5pjlvufs4znnhhkwe8v4tw3kz30f3lxgwza53"}`
expected := `{"type":"desmos/MsgAddUserToUserGroup","value":{"group_id":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1","user":"cosmos1x5pjlvufs4znnhhkwe8v4tw3kz30f3lxgwza53"}}`
require.Equal(t, expected, string(msgAddUserToGroup.GetSignBytes()))
}

Expand Down Expand Up @@ -728,7 +728,7 @@ func TestMsgRemoveUserFromUserGroup_ValidateBasic(t *testing.T) {
}

func TestMsgRemoveUserFromUserGroup_GetSignBytes(t *testing.T) {
expected := `{"group_id":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1","user":"cosmos1x5pjlvufs4znnhhkwe8v4tw3kz30f3lxgwza53"}`
expected := `{"type":"desmos/MsgRemoveUserFromUserGroup","value":{"group_id":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1","user":"cosmos1x5pjlvufs4znnhhkwe8v4tw3kz30f3lxgwza53"}}`
require.Equal(t, expected, string(msgRemoveUserFromUserGroup.GetSignBytes()))
}

Expand Down Expand Up @@ -819,7 +819,7 @@ func TestMsgSetUserPermissions_ValidateBasic(t *testing.T) {
}

func TestMsgSetUserPermissions_GetSignBytes(t *testing.T) {
expected := `{"permissions":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1","user":"cosmos1x5pjlvufs4znnhhkwe8v4tw3kz30f3lxgwza53"}`
expected := `{"type":"desmos/MsgSetUserPermissions","value":{"permissions":1,"signer":"cosmos1m0czrla04f7rp3zg7dsgc4kla54q7pc4xt00l5","subspace_id":"1","user":"cosmos1x5pjlvufs4znnhhkwe8v4tw3kz30f3lxgwza53"}}`
require.Equal(t, expected, string(msgSetUserPermissions.GetSignBytes()))
}

Expand Down