fix!: remove supply store key #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=======================================
Coverage 81.71% 81.71%
=======================================
Files 110 110
Lines 9255 9256 +1
=======================================
+ Hits 7563 7564 +1
Misses 1370 1370
Partials 322 322
Continue to review full report at Codecov.
|
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
leobragaz
approved these changes
May 30, 2022
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
RiccardoM
added
requires-upgrade
…remove-supply-store-key � Conflicts: � .changeset/config.yaml � app/app.go
leobragaz
approved these changes
May 30, 2022
dadamu
reviewed
May 31, 2022
app/upgrades/v320/upgrade.go
Outdated
| // StoreUpgrades implements upgrades.Upgrade | ||
| func (u *Upgrade) StoreUpgrades() *storetypes.StoreUpgrades { | ||
| return &storetypes.StoreUpgrades{ | ||
| Added: []string{ |
There was a problem hiding this comment.
You're totally right! Thanks for spotting this 🙏 My bad
…remove-supply-store-key
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
dadamu
approved these changes
May 31, 2022
RiccardoM
added a commit
that referenced
this pull request
May 31, 2022
## Description This PR removes the `supply` store key that was wrongfully added to the app's store keys and was causing the following error: ``` panic: cannot delete latest saved version (XXXX) ``` ### Bug description Previously to `v0.42.0` the Cosmos SDK used a store key named `supply` to store the current supply of the tokens within the `x/supply` module. With `v0.42.0` the `x/supply` module was merged into the `x/bank` module, but the store key was never deleted with any on-chain upgrade. With version `v3.1.0` and the introduction of our own `x/supply` module, we wrongfully added a store key named the same way (`supply`) to the app store keys (see [here](7481644#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7R339)). This caused the application to crash during the loading of the store, as: 1. the latest saved version of the `supply` store was set to a very old height, and 2. the actual latest block height was a lot higher than that value. Once this happens, usually the older versions of stores are deleted following the pruning strategy of the node. In this case though the `supply` store should have been deleted entirely, but Cosmos does not allow deleting the latest saved version of a store (unless we use an on-chain upgrade to remove the key). This is what caused the above error. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 4e7527d) Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
supplystore key that was wrongfully added to the app's store keys and was causing the following error:Bug description
Previously to
v0.42.0the Cosmos SDK used a store key namedsupplyto store the current supply of the tokens within thex/supplymodule. Withv0.42.0thex/supplymodule was merged into thex/bankmodule, but the store key was never deleted with any on-chain upgrade.With version
v3.1.0and the introduction of our ownx/supplymodule, we wrongfully added a store key named the same way (supply) to the app store keys (see here). This caused the application to crash during the loading of the store, as:supplystore was set to a very old height, andOnce this happens, usually the older versions of stores are deleted following the pruning strategy of the node. In this case though the
supplystore should have been deleted entirely, but Cosmos does not allow deleting the latest saved version of a store (unless we use an on-chain upgrade to remove the key). This is what caused the above error.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change