Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update wasm parser for v1.0.0 cosmwasm std #946

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Jun 28, 2022

Description

Closes: #XXXX
Due to the wasm size issue after updating to cosmwasm-std v1.0.0, the custom serde tag is removed from desmos binding. This PR updates the wasm parser to the new json message.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #946 (227a73a) into master (c6fd7b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #946   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files         167      167           
  Lines       14132    14132           
=======================================
  Hits        11674    11674           
  Misses       1979     1979           
  Partials      479      479           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6fd7b6...227a73a. Read the comment docs.

cosmwasm/msg_parser.go Outdated Show resolved Hide resolved
cosmwasm/msg_parser.go Outdated Show resolved Hide resolved
cosmwasm/query_parser.go Outdated Show resolved Hide resolved
dadamu and others added 2 commits June 28, 2022 21:40
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@dadamu dadamu requested a review from leobragaz June 28, 2022 13:52
Copy link

@manu0466 manu0466 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@manu0466 manu0466 added automerge Automatically merge PR once all prerequisites pass cosmwasm Extend functionality to devs labels Jun 28, 2022
@mergify mergify bot merged commit 9a23dbd into master Jun 28, 2022
@mergify mergify bot deleted the paul/DCD-20/update-wasm-parser branch June 28, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass cosmwasm Extend functionality to devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants