Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing profiles params upgrade #980

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jul 29, 2022

Description

This PR adds the x/profiles params upgrade that was missing inside v4.2.0 and is currently causing errors when trying to store a profile (see here).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@github-actions github-actions bot added the x/profiles Module that allows to create and manage decentralized social profiles label Jul 29, 2022
@RiccardoM RiccardoM changed the title fix: fix profiles params upgrade fix: missing profiles params upgrade Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #980 (f05b009) into master (987ec5d) will decrease coverage by 0.00%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
- Coverage   80.53%   80.52%   -0.01%     
==========================================
  Files         172      173       +1     
  Lines       15244    15252       +8     
==========================================
+ Hits        12277    12282       +5     
- Misses       2440     2443       +3     
  Partials      527      527              
Impacted Files Coverage Δ
x/profiles/module.go 9.75% <0.00%> (-0.38%) ⬇️
x/profiles/legacy/v7/store.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da714ce...f05b009. Read the comment docs.

@RiccardoM RiccardoM changed the title fix: missing profiles params upgrade fix: add missing profiles params upgrade Jul 29, 2022
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jul 29, 2022
@mergify mergify bot merged commit e407869 into master Jul 29, 2022
@mergify mergify bot deleted the riccardom/fix-profiles-params-upgrade branch July 29, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants