Use big floats #665
Merged
Use big floats #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
diamondhands0
approved these changes
Aug 6, 2024
| if big.NewFloat(0.0).Add( | ||
| baseCurrencyFilled, | ||
| big.NewFloat(bid.AmountInBaseCurrency), | ||
| ).Cmp(baseCurrencyToFill) > 1 { |
There was a problem hiding this comment.
Shouldn't this be >0 rather than >1? I can't remember but I think it returns -1 = "less than" and 1 = "greater than" so you want to Cmp to zero.
| big.NewFloat(bid.AmountInBaseCurrency), | ||
| ).Cmp(baseCurrencyToFill) > 1 { | ||
| baseCurrencyFromThisOrder := big.NewFloat(0).Sub(baseCurrencyToFill, baseCurrencyFilled) | ||
| quoteCurrencyReceived = big.NewFloat(0).Mul(baseCurrencyFromThisOrder, big.NewFloat(bid.PriceInQuoteCurrency)) |
There was a problem hiding this comment.
I think this needs to be += for this case to work properly.
lazynina
force-pushed
the
ln/get-base-currency-price-big-float
branch
2 times, most recently
from
f3ea4b7
to
0dcb067
Compare
lazynina
force-pushed
the
ln/get-base-currency-price
branch
from
682f70e
to
a256567
Compare
lazynina
force-pushed
the
ln/get-base-currency-price-big-float
branch
from
0dcb067
to
095f77f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.