-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ln/max tip age bug fix #1392
Ln/max tip age bug fix #1392
Changes from all commits
cf6b388
6e5c750
9e12445
4bd3da6
6e1832d
4ff30d2
6f2ffdb
158a883
8aee1ef
e407011
f34099f
b79de43
01ba0c2
94439ce
fc8ea8f
a40c05f
ca0e94d
ca996ab
7d6708d
f2426c9
be7f2e7
d67fd0c
31fa104
b893c1b
aaef35c
f92a9d8
281d368
6c2b1eb
6b6b153
1ea1e6d
11bc4d4
8c97a24
b9c8a6e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1110,7 +1110,7 @@ var DeSoMainnetParams = DeSoParams{ | |
MinChainWorkHex: "000000000000000000000000000000000000000000000000006314f9a85a949b", | ||
|
||
MaxTipAgePoW: 24 * time.Hour, | ||
MaxTipAgePoS: time.Hour, | ||
MaxTipAgePoS: 24 * time.Hour, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok so I have a question: If we're syncing from scratch, do we use MaxTipAgePoS to mark when we start checking block signatures? Because that would make sync take a lot longer unnecessarily. If this is NOT the case, then I like 24h as the time. If it IS the case, then maybe just do 3h or something more conservative until we can break that signature checking thing into its own flag... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll lower to 3 hours - this does make us start checking signatures sooner. |
||
|
||
// =================================================================================== | ||
// Mainnet Bitcoin config | ||
|
@@ -1544,7 +1544,7 @@ var DeSoTestnetParams = DeSoParams{ | |
// TODO: Set to one day when we launch the testnet. In the meantime this value | ||
// is more useful for local testing. | ||
MaxTipAgePoW: time.Hour * 24, | ||
MaxTipAgePoS: time.Hour, | ||
MaxTipAgePoS: time.Hour * 24, | ||
|
||
// Difficulty can't decrease to below 50% of its previous value or increase | ||
// to above 200% of its previous value. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied this thing pretty quickly, but I think we need to keep it generally so I'd leave it. If you don't have it then it literally can't process comma-separated values when you pass them as env vars.