Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename layouts to sort alphabetically better #702

Closed
6 of 7 tasks
BlueDrink9 opened this issue Feb 9, 2024 · 11 comments
Closed
6 of 7 tasks

Rename layouts to sort alphabetically better #702

BlueDrink9 opened this issue Feb 9, 2024 · 11 comments

Comments

@BlueDrink9
Copy link
Contributor

Describe your suggested feature

Currently variants of keyboards are named like "[language] [variant] [base]", eg "english symbols thumb-key" and "english thumb-key". That means that in the keyboard list, they don't sort together.

I'd like to propose renaming them to be [lang] [base] [variant], so we get "english symbols messagease left" sorting with "english messagease".

Other details

Opening this as an issue rather than doing it immediately just to avoid having too many PRs open, and to check you'd be welcome to the change.

Acknowledgements

  • I have searched the existing issues and this is a new one, NOT a duplicate or related to another open issue.
  • This is a single feature request, in case of multiple feature requests I will open a separate issue for each one (they can always link to each other if related)
  • This is not a question or a discussion, in which case I should have gone to lemmy.ml/c/thumbkey
  • I have written a short but informative title.
  • I have checked through the app settings for my feature.
  • I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements. 🤡
  • I will fill out all of the requested information in this form.
@smurfix
Copy link

smurfix commented Feb 9, 2024

Actually a two-level hierarchy would be nice. Or even something more flexible. The single list is too long already, and with all the MessagEase refugees it's only going to get longer.

@BlueDrink9
Copy link
Contributor Author

BlueDrink9 commented Feb 9, 2024 •
edited
Loading

that's been discussed pretty extensively; check through other issues. What I'm talking about here is as a stop-gap solution

@dessalines
Copy link
Owner

I'd like to propose renaming them to be [lang] [base] [variant], so we get "english symbols messagease left" sorting with "english messagease".

That's actually [lang] [qualifier] [base] [qualifier] , which doesn't make much sense to me. Best to group the qualifiers / variants together, and have the [base] at the end.

@BlueDrink9
Copy link
Contributor Author

Can you talk me through your reasoning? Messagease/thumb-key seem like a "base" to me, is that where we differ?

For users, they likely only care about the options for their language, so sorting them together makes sense.

May have to table this for the tag system though

@dessalines
Copy link
Owner

dessalines commented Feb 9, 2024 •
edited
Loading

I'm suggesting that we stick with the current naming:

[langs] [qualifiers] [base]

Qualifiers include things like symbols, programmer, etc.

I spose I don't care whether base comes before qualifier, as long as we keep qualifiers in a single group.

@BlueDrink9
Copy link
Contributor Author

BlueDrink9 commented Feb 9, 2024 •
edited
Loading

Oh yup I agree, my bad example. I meant en sym ME left would be renamed to en ME sym left, just didn't type it out fully

Also thanks for taking the time to address my questions and reviews

@dessalines
Copy link
Owner

No probs. en ME sym left IE

[langs] [base] [qualifiers] would also work, but someone would need to go through every layout title, and I'm not sure its worth it.

@BlueDrink9
Copy link
Contributor Author

I'll do it, looks fairly regexable

@dessalines
Copy link
Owner

Can re-open if someone wants to work on this.

@dessalines dessalines closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
@mpsijm mpsijm mentioned this issue Aug 6, 2024
Merged
mpsijm added a commit to mpsijm/thumb-key that referenced this issue Aug 6, 2024
@mpsijm
dessalines#702 Rewrite titles of layouts to `[languages] [base] [qual…
34bca61 
…ifiers] [version]`

`[languages]` are languages or "alphabets", for example:
- canadian aboriginal syllabic
- english
- english deutsch
- esperanto english deutsch
- japanese hiragana
- japanese kana
- japanese katakana
- ...

`[base]` is the name of the original layout:
- messagease
- qbased
- qwertease
- qwertyfour
- thumb-key
- type-split

`[qualifiers]` are additional features/modifiers of the layout, in alphabetical order:
- +æ
- +åæø
- compose
- double symbols
- emoji
- left-handed
- phonetic
- programming
- samsung
- symbols
- symbols-numbers
- two-hands
- wide (may be the same as "two-hands"?)
- writer

`[version]` is a `v` followed by a number:
- v1
- v2
- v3
mpsijm added a commit to mpsijm/thumb-key that referenced this issue Aug 6, 2024
@mpsijm
dessalines#702 Also rename constants to match layout titles
da5e866
mpsijm added a commit to mpsijm/thumb-key that referenced this issue Aug 6, 2024
@mpsijm
dessalines#702 Add layout naming guideline to README
0d07312
@mpsijm
Copy link
Contributor

mpsijm commented Aug 6, 2024 •
edited
Loading

I've spent some time on renaming things, what do you think? 🙂
In mpsijm@34bca61, I've renamed the layout titles.
See mpsijm/thumb-key@main...mpsijm:thumb-key:702-rename-layouts for all my changes so far (also renaming the constants).

mpsijm added a commit to mpsijm/thumb-key that referenced this issue Aug 6, 2024
@mpsijm
dessalines#702 Rewrite titles of layouts to `[languages] [base] [qual…
5687e3c 
…ifiers] [version]`

`[languages]` are languages or "alphabets", for example:
- canadian aboriginal syllabic
- english
- english deutsch
- esperanto english deutsch
- japanese hiragana
- japanese kana
- japanese katakana
- ...

`[base]` is the name of the original layout:
- messagease
- qbased
- qwertease
- qwertyfour
- thumb-key
- type-split

`[qualifiers]` are additional features/modifiers of the layout, in alphabetical order:
- +æ
- +åæø
- compose
- double symbols
- emoji
- left-handed
- phonetic
- programming
- samsung
- symbols
- symbols-numbers
- two-hands
- wide (may be the same as "two-hands"?)
- writer

`[version]` is a `v` followed by a number:
- v1
- v2
- v3
mpsijm added a commit to mpsijm/thumb-key that referenced this issue Aug 6, 2024
@mpsijm
dessalines#702 Also rename constants to match layout titles
45ca55c
mpsijm added a commit to mpsijm/thumb-key that referenced this issue Aug 6, 2024
@mpsijm
dessalines#702 Add layout naming guideline to README
5b5a5f1
@dessalines
Copy link
Owner

@mpsijm Those all look good so far! Feel free to open up a draft PR, then mark it as ready for review whenever.

mpsijm added a commit to mpsijm/thumb-key that referenced this issue Aug 7, 2024
@mpsijm
dessalines#702 Rewrite titles of layouts to `[languages] [base] [qual…
7172dd9 
…ifiers] [version]`

`[languages]` are languages or "alphabets", for example:
- canadian aboriginal syllabic
- english
- english deutsch
- esperanto english deutsch
- japanese hiragana
- japanese kana
- japanese katakana
- ...

`[base]` is the name of the original layout:
- messagease
- qbased
- qwertease
- qwertyfour
- thumb-key
- type-split

`[qualifiers]` are additional features/modifiers of the layout, in alphabetical order:
- +æ
- +åæø
- compose
- double symbols
- emoji
- left-handed
- phonetic
- programming
- samsung
- symbols
- symbols-numbers
- two-hands
- wide (may be the same as "two-hands"?)
- writer

`[version]` is a `v` followed by a number:
- v1
- v2
- v3
mpsijm added a commit to mpsijm/thumb-key that referenced this issue Aug 7, 2024
@mpsijm
dessalines#702 Also rename constants to match layout titles
6553d75
mpsijm added a commit to mpsijm/thumb-key that referenced this issue Aug 7, 2024
@mpsijm
dessalines#702 Add layout naming guideline to README
2b8ac44
@mpsijm mpsijm mentioned this issue Aug 7, 2024
Merged
dessalines added a commit that referenced this issue Aug 7, 2024
@mpsijm @dessalines
#702 Rewrite titles of layouts to `[languages] [base] [qualifiers] [v…
629bb38 
…ersion]` (#1007)

* #702 Rewrite titles of layouts to `[languages] [base] [qualifiers] [version]`

`[languages]` are languages or "alphabets", for example:
- canadian aboriginal syllabic
- english
- english deutsch
- esperanto english deutsch
- japanese hiragana
- japanese kana
- japanese katakana
- ...

`[base]` is the name of the original layout:
- messagease
- qbased
- qwertease
- qwertyfour
- thumb-key
- type-split

`[qualifiers]` are additional features/modifiers of the layout, in alphabetical order:
- +æ
- +åæø
- compose
- double symbols
- emoji
- left-handed
- phonetic
- programming
- samsung
- symbols
- symbols-numbers
- two-hands
- wide (may be the same as "two-hands"?)
- writer

`[version]` is a `v` followed by a number:
- v1
- v2
- v3

* #702 Also rename constants to match layout titles

* #702 Add layout naming guideline to README

---------

Co-authored-by: Dessalines <tyhou13@gmx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smurfix @dessalines @mpsijm @BlueDrink9