Add more actions for changing keyboard position #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Seems fine to me, although in the future we may need to tweak this to account for #783 , which would allow a fine position adjustment, not just left, center, right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add actions to move keyboard to a specified position, or in a specified direction.
The existing layouts only use the
CycleRightoption, but the extra ones are handy for custom layouts. For example, my fork has two separate keys for moving the keyboard right and left respectively, because I switch hands often.