Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rclone to conda-requirements.txt #19

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Add rclone to conda-requirements.txt #19

merged 2 commits into from
Apr 26, 2024

Conversation

annefou
Copy link
Collaborator

@annefou annefou commented Apr 19, 2024

No description provided.

@annefou annefou requested a review from minrk April 26, 2024 08:55
@annefou
Copy link
Collaborator Author

annefou commented Apr 26, 2024

@minrk I also would like to add the associated configuration files but I am not sure where to add them.

@minrk
Copy link
Collaborator

minrk commented Apr 26, 2024

what files should go where? That probably belongs in the Dockerfile

@annefou
Copy link
Collaborator Author

annefou commented Apr 26, 2024

what files should go where? That probably belongs in the Dockerfile

that is what I thought but we also need to have the user credentials for our buckets.

Below is what I have put in $HOME/.config/rclone/rclone.conf (manually and with correct access_key_id and secret_access_key):

[cmarine]
type = s3
provider = Other
endpoint = https://s3.waw3-1.cloudferro.com
acl = public-read

[gfts]
type = s3
provider = Other
env_auth = true
access_key_id = XXX
secret_access_key = YYY
endpoint = https://s3.gra.perf.cloud.ovh.net
profile = gfts
region = gra

@minrk
Copy link
Collaborator

minrk commented Apr 26, 2024

it shouldn't need the access key or profile with env_auth = true, so I think the same file works for everyone. This config worked for me:

[gfts]
type = s3
provider = Other
env_auth = true
region = gra
endpoint = https://s3.gra.perf.cloud.ovh.net

@annefou
Copy link
Collaborator Author

annefou commented Apr 26, 2024

then I can add it in the repo and docker file, right?

@minrk
Copy link
Collaborator

minrk commented Apr 26, 2024

We'll still need to copy it into home in an initContainer here, so might as well create it there, rather than needing to update the image.

I can do that, if you want.

@minrk minrk merged commit 93d5b8e into main Apr 26, 2024
2 checks passed
@minrk minrk deleted the add-rclone branch April 26, 2024 09:33
@annefou
Copy link
Collaborator Author

annefou commented Apr 26, 2024

We'll still need to copy it into home in an initContainer here, so might as well create it there, rather than needing to update the image.

I can do that, if you want.

Out of curiosity, why can't we copy it in the docker file (and have the config file in https://github.com/destination-earth/DestinE_ESA_GFTS/tree/main/jupyterhub/images/user) e.g. updating the current Dockerfile with something like:

WORKDIR /home/$NB_USER
RUN mkdir -p ./.config/rclone
COPY rclone.conf ./.config/rclone

@minrk
Copy link
Collaborator

minrk commented Apr 26, 2024

$HOME is a mounted volume in the container, it doesn't come from the image. Files in $HOME in the image will not be available in the container.

That would work if we had no persistence of your home directory.

@annefou
Copy link
Collaborator Author

annefou commented Apr 26, 2024

Ok! I got it. just to understand: in here, would you generate the config file on the fly?

@minrk
Copy link
Collaborator

minrk commented Apr 26, 2024

yes, that's right

@annefou
Copy link
Collaborator Author

annefou commented Apr 26, 2024

Ok. then let me try...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants