-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MetadataType Attribute #140
Open
digitalsigi
wants to merge
9
commits into
destructurama:metadata
Choose a base branch
from
digitalsigi:metadata
base: metadata
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+161
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
tests
Pull request that adds new or changes existing tests
labels
Dec 18, 2024
sungam3r
reviewed
Dec 20, 2024
Fine with me Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
sungam3r
reviewed
Dec 20, 2024
Thank you. Much better explaination! Actually this is my first contribution to such a project... Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
sungam3r
reviewed
Dec 20, 2024
sungam3r
reviewed
Dec 20, 2024
sungam3r
reviewed
Dec 20, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Dec 20, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Dec 20, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
tests
Pull request that adds new or changes existing tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support from MetadataType Attribute, see #40
According to https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.dataannotations.metadatatypeattribute?view=net-9.0#remarks
Changed code replaces the PropertyInfo from base class with PropertyInfo property of MetadataType for equal named properties.