Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dipole element name overwriting #181

Closed
jp-ga opened this issue Jun 18, 2024 · 1 comment · Fixed by #186
Closed

Dipole element name overwriting #181

jp-ga opened this issue Jun 18, 2024 · 1 comment · Fixed by #186
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jp-ga
Copy link
Collaborator

jp-ga commented Jun 18, 2024

I was checking dipole.py and saw this:

self.name = name

It might be overwriting the name generated from the Element class init :

self.name = name if name is not None else generate_unique_name()

@jank324 jank324 added the bug Something isn't working label Jun 18, 2024
@jank324
Copy link
Member

jank324 commented Jun 18, 2024

Yeah ... I think this is an issue and the line in dipole.py should be removed. We should also check if other elements do the same thing.

@jank324 jank324 added the good first issue Good for newcomers label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants