Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure dipoles get a unique name #186

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

Hespe
Copy link
Member

@Hespe Hespe commented Jun 19, 2024

Description

Removes an unnecessary name assignment within the dipole element to ensure all accelerator elements are assigned unique names if none are provided.

Motivation and Context

Closes #181

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@Hespe
Copy link
Member Author

Hespe commented Jun 19, 2024

I checked all other elements as well and none seem to have the same unnecessary overwrite.
Not sure though which line in quadrupole.py you meant in #181, @jank324?

@jank324
Copy link
Member

jank324 commented Jun 19, 2024

I think I meant dipole.py. It was late and I was working on multiple issues at the same time. 😄

@jank324 jank324 merged commit 1089b1e into desy-ml:master Jun 19, 2024
6 checks passed
@Hespe Hespe deleted the 181-name-overwriting branch June 19, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dipole element name overwriting
2 participants