Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of RBend entrance and exit face angles #298

Open
cr-xu opened this issue Dec 3, 2024 · 1 comment
Open

Better handling of RBend entrance and exit face angles #298

cr-xu opened this issue Dec 3, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@cr-xu
Copy link
Member

cr-xu commented Dec 3, 2024

@cr-xu we are struggling with this PR a bit and I think you might have useful input.

In RBend there might be an issue with e1 and e2. If I instantiate an RBend and then access my_rbend.e1, the e1 I get is different from the one I set in the instantiation, by being in "Dipole space" rather than "RBend space". I believe that's an issue.

@Hespe and I were brainstorming solutions and one idea was to define two different e1 and e2 ... something like dipole_e1 and rbend_e1, where rbend_e1 would just be a computed property of the RBend class that computes based on dipole_e1.

What are your thoughts on this? Are you aware of any conventions already present in other codes or in general notation?

Originally posted by @jank324 in #289 (comment)

  • The RBend should have new properties that agree with the values set by the users to avoid confusion. (Solved by Add clone method for beams and elements #289)
  • Better documentation showing the difference in e1 and e2 for Dipole (SBend) and RBend
@cr-xu cr-xu added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 3, 2024
@cr-xu cr-xu self-assigned this Dec 3, 2024
@cr-xu
Copy link
Member Author

cr-xu commented Dec 3, 2024

For example, a similar treatment is done in bmad (c.f. bmad manual Chapter 4.5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant