-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clone
method for beams and elements
#289
Conversation
Would be wise to merge this PR after #284 such that |
Looks like the |
The second test failure should be fixed once #288 is merged. |
@jank324 There are some lines in the plotting tests that change context beyond their own scope: cheetah/tests/test_plotting.py Lines 16 to 20 in 01dbf8e
Not sure if we should adjust that somehow or if its fine in this case. |
Raised this issue in #290 |
#288 is merged now. |
The plotting related failure is now fixed. This leaves only #290 as a blocker for this PR. |
@Hespe I can't officially request a review, so here is an unofficial request. |
Looks good to me except for these two comments about potentially missing features in the |
Apart from that, it's good to go from my side. |
Description
There is currently no reliable way to obtain copies of
Beam
orElement
. This has lead tocopy.deepcopy
being used in some places which is troublesome in some instances (see the issues linked below).Motivation and Context
plot_reference_particle_traces
crashes for non-leaf tensors #285Types of changes
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line.