Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Bmad conversion device passing #196

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

jank324
Copy link
Member

@jank324 jank324 commented Jun 26, 2024

Description

Makes sure that device can be passed to the element initialisations when using Segment.from_bmad.

Motivation and Context

This is needed to be able to load Bmad lattices on a device other than "cpu". Closes #195.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@jank324 jank324 added bug Something isn't working enhancement New feature or request labels Jun 26, 2024
@jank324 jank324 self-assigned this Jun 26, 2024
@jank324 jank324 linked an issue Jun 26, 2024 that may be closed by this pull request
@jank324 jank324 marked this pull request as ready for review June 26, 2024 14:08
@jank324 jank324 requested a review from cr-xu June 26, 2024 14:09
@cr-xu cr-xu merged commit 2f6a332 into master Jun 26, 2024
11 checks passed
@jank324 jank324 deleted the 195-bmad-import-does-not-pass-device branch June 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bmad import does not pass device
2 participants