-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix twiss plot #213
Fix twiss plot #213
Conversation
Plotting currently still fails if the segment is broadcasted beforehand. The problem is caused by the incompatible splitting implementation (#227). |
tests/test_plotting.py
Outdated
) | ||
|
||
# Run the plotting to see if it raises an exception | ||
segment.plot_twiss(incoming, vector_idx=(0, 2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's still in progress or @jank324 you forgot to push the updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on it right now.
Description
Fixes a bug in the Twiss plot.
Motivation and Context
The Twiss plot was failing because it was not yet made compatible with vectorised Cheetah.
Types of changes
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line