Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix twiss plot #213

Merged
merged 19 commits into from
Oct 4, 2024
Merged

Fix twiss plot #213

merged 19 commits into from
Oct 4, 2024

Conversation

jank324
Copy link
Member

@jank324 jank324 commented Jul 9, 2024

Description

Fixes a bug in the Twiss plot.

Motivation and Context

The Twiss plot was failing because it was not yet made compatible with vectorised Cheetah.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@jank324 jank324 added the bug Something isn't working label Jul 9, 2024
@jank324 jank324 self-assigned this Jul 9, 2024
@jank324 jank324 marked this pull request as ready for review July 9, 2024 19:16
@jank324 jank324 requested a review from cr-xu July 9, 2024 19:16
@jank324 jank324 mentioned this pull request Jul 10, 2024
7 tasks
@Hespe
Copy link
Member

Hespe commented Jul 24, 2024

Plotting currently still fails if the segment is broadcasted beforehand. The problem is caused by the incompatible splitting implementation (#227).

)

# Run the plotting to see if it raises an exception
segment.plot_twiss(incoming, vector_idx=(0, 2))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's still in progress or @jank324 you forgot to push the updates?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on it right now.

@jank324 jank324 requested a review from cr-xu October 3, 2024 16:53
@jank324 jank324 mentioned this pull request Oct 3, 2024
14 tasks
@cr-xu cr-xu merged commit c96f3c4 into master Oct 4, 2024
8 checks passed
@Hespe Hespe deleted the fix_twiss_plot branch December 16, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants