Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let broadcast keep the dtype and device #218

Merged

Conversation

cr-xu
Copy link
Member

@cr-xu cr-xu commented Jul 10, 2024

Now broadcasting elements and beams will keep the dtype and device

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@cr-xu cr-xu linked an issue Jul 10, 2024 that may be closed by this pull request
@cr-xu cr-xu requested a review from jank324 July 10, 2024 08:22
@jank324 jank324 merged commit a743bf1 into master Jul 10, 2024
11 checks passed
@jank324 jank324 deleted the 217-broadcast-doesnt-keep-dtype-for-beam-classes-and-elements branch July 10, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broadcast doesn't keep dtype for beam classes and elements
2 participants