Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Installation of NumPy 2.0 #220

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

Hespe
Copy link
Member

@Hespe Hespe commented Jul 16, 2024

Description

The setup.py is updated to add a requirement of installing numpy < 2.0.

Motivation and Context

The changes required for NumPy 2.0 are not yet complete in PyTorch (#177).
In order to move ahead with the 0.7 release, we therefore limit the installed numpy version.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@jank324 jank324 self-requested a review July 16, 2024 14:44
@jank324 jank324 added the bug Something isn't working label Jul 16, 2024
@jank324 jank324 merged commit b38a654 into desy-ml:master Jul 16, 2024
6 checks passed
@Hespe Hespe deleted the 177-numpy-two branch August 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants