Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent GitHub Actions from running twice every time #244

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

jank324
Copy link
Member

@jank324 jank324 commented Aug 26, 2024

Description

Adds a more restrictive on configuration to GitHub Actions. These are copied from theStable Baselines3 repository.

Motivation and Context

This change halts the number of runs performed in each PR, because previously each run was triggered twice. Consequentially, the time taken for automatic testing etc. is effectively halved.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line.

@jank324 jank324 marked this pull request as ready for review August 26, 2024 10:22
@jank324 jank324 requested a review from cr-xu August 26, 2024 10:22
@cr-xu cr-xu merged commit 0f2b0ac into master Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants