-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine Elegant lattice converter #251
Conversation
I have opted not to remove all traces of a potential charge element from the imported lattice, but instead to replace it with a |
@Hespe can you make sure that the changes in this PR follow the new broadcasting semantics? |
There are a lot of square bracket in the Elegant converter that are probably no longer necessary with the broadcasting rules. They are, however, mostly in parts of the code that is not affected by this PR. Should we address that here, or leave it for another time? Doing it partially seems wrong. |
Description
In the elegant lattice definition, there exist several aliases for already implemented cheetah
Elements
that prevent a sucessful import. This PR ensures that also the aliased elements can be imported without trouble.Motivation and Context
Types of changes
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line.