Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent shadowing of parameters method in Beam #300

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

Hespe
Copy link
Member

@Hespe Hespe commented Dec 5, 2024

Description

Beam currently shadows torch.nn.Module.parameters(), completely changing its behaviour. This PR removes the custom implementation and is therefore a breaking change.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line.

@Hespe Hespe added the bug Something isn't working label Dec 5, 2024
@Hespe Hespe requested a review from jank324 December 5, 2024 13:19
@Hespe Hespe self-assigned this Dec 5, 2024
@jank324 jank324 merged commit abcd6fc into desy-ml:master Dec 5, 2024
8 checks passed
@Hespe Hespe deleted the 282-shadowing branch December 5, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beam shadows parameters method inherited from torch.nn.Module
2 participants