add async_halving

determined-ai · Oct 8, 2024 · a4d190f · a4d190f
1 parent 8abc798
commit a4d190f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/master/pkg/searcher/adaptive_asha.go b/master/pkg/searcher/adaptive_asha.go
@@ -110,7 +110,6 @@ func makeBrackets(config expconf.AdaptiveASHAConfig) []bracket {
 
 func newAdaptiveASHASearch(config expconf.AdaptiveASHAConfig, smallerIsBetter bool, metric string) SearchMethod {
  brackets := makeBrackets(config)
- fmt.Printf("Brackets: %v\n", brackets)
  methods := make([]SearchMethod, 0, len(brackets))
  for _, bracket := range brackets {
  c := expconf.AsyncHalvingConfig{

diff --git a/master/pkg/searcher/search_method.go b/master/pkg/searcher/search_method.go
@@ -51,8 +51,6 @@ const (
  RandomSearch SearchMethodType = "random"
  // GridSearch is the SearchMethodType for a grid searcher.
  GridSearch SearchMethodType = "grid"
- // AdaptiveSearch is the SearchMethodType for an adaptive searcher.
- AdaptiveSearch SearchMethodType = "adaptive"
  // ASHASearch is the SearchMethodType for an ASHA searcher.
  ASHASearch SearchMethodType = "asha"
  // AdaptiveASHASearch is the SearchMethodType for an adaptive ASHA searcher.
@@ -68,6 +66,8 @@ func NewSearchMethod(c expconf.SearcherConfig) SearchMethod {
  return newRandomSearch(*c.RawRandomConfig)
  case c.RawGridConfig != nil:
  return newGridSearch(*c.RawGridConfig)
+ case c.RawAsyncHalvingConfig != nil:
+ return newAsyncHalvingStoppingSearch(*c.RawAsyncHalvingConfig, c.SmallerIsBetter(), c.Metric())
  case c.RawAdaptiveASHAConfig != nil:
  return newAdaptiveASHASearch(*c.RawAdaptiveASHAConfig, c.SmallerIsBetter(), c.Metric())
  default:

diff --git a/schemas/expconf/v0/searcher-async-halving.json b/schemas/expconf/v0/searcher-async-halving.json
@@ -70,6 +70,20 @@
  ],
  "default": null
  },
+ "time_metric": {
+ "type": [
+ "string",
+ "null"
+ ],
+ "default": null
+ },
+ "max_time": {
+ "type": [
+ "integer",
+ "null"
+ ],
+ "default": null
+ },
  "smaller_is_better": {
  "type": [
  "boolean",