fix: use UID not username to set HOME dir #10010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a task's uid setting is nonzero but username is still "root", we will accidentally set the HOME directory to /root. This happens because we start the container based on the UID, then we look up the username (uid->username lookup) and we find that we are called "root", then we do a username->HOME lookup to arrive at /root.
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10010 +/- ##
=======================================
Coverage 54.56% 54.57%
=======================================
Files 1259 1259
Lines 157233 157233
Branches 3619 3619
=======================================
+ Hits 85802 85806 +4
+ Misses 71298 71294 -4
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
stoksc
approved these changes
Oct 2, 2024
|
oops, I meant to enable auto-merge but it looks like I accidentally force-merged. Should be ok, the only remaining failure was a flaky e2e web test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task's uid setting is nonzero but username is still "root", we will accidentally set the HOME directory to /root.
This happens because we start the container based on the UID, then we look up the username (uid->username lookup) and we find that we are called "root", then we do a username->HOME lookup to arrive at /root.