chore: wait_for_task_state shows logs on failure #10029
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10029 +/- ##
==========================================
- Coverage 54.63% 54.60% -0.03%
==========================================
Files 1259 1259
Lines 157358 157358
Branches 3616 3615 -1
==========================================
- Hits 85966 85919 -47
- Misses 71259 71306 +47
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
Before, it wasn't using the session to fetch logs.
rb-determined-ai
force-pushed
the
rb/e2e-task-logs
branch
from
24ae99f
to
1a5ce10
Compare
rb-determined-ai
requested review from
ShreyaLnuHpe
and removed request for
stoksc
maxrussell
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, it wasn't using the session to fetch logs.