Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove max_length from WebUI #10033

Closed
wants to merge 3 commits into from
Closed

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Oct 9, 2024

Ticket

MD-527

Description

Part of searcher context removal project.
Remove max_length for searchers in WebUI

Test Plan

Continue/Fork/HPSearch work as expected with the right backend.
Tests passed.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 636289d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6706ea3195ea9d00083044f1
😎 Deploy Preview https://deploy-preview-10033--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 50.55%. Comparing base (c27054d) to head (765da1c).
Report is 107 commits behind head on main.

Files with missing lines Patch % Lines
...i/react/src/components/ExperimentContinueModal.tsx 81.81% 2 Missing ⚠️
...ages/ExperimentDetails/ExperimentDetailsHeader.tsx 60.00% 2 Missing ⚠️
...bui/react/src/components/ExperimentCreateModal.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10033      +/-   ##
==========================================
- Coverage   54.60%   50.55%   -4.05%     
==========================================
  Files        1259      949     -310     
  Lines      157366   128485   -28881     
  Branches     3617     3595      -22     
==========================================
- Hits        85931    64958   -20973     
+ Misses      71302    63394    -7908     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.33% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/components/CompareHyperparameters.test.mock.tsx 100.00% <ø> (ø)
.../react/src/components/ComparisonView.test.mock.tsx 99.30% <ø> (-0.01%) ⬇️
...react/src/components/HyperparameterSearchModal.tsx 90.46% <ø> (-0.07%) ⬇️
...s/ExperimentDetails/ExperimentDetails.test.mock.ts 100.00% <ø> (ø)
webui/react/src/types.ts 99.70% <ø> (-0.01%) ⬇️
webui/react/src/utils/experiment.ts 90.79% <ø> (+0.86%) ⬆️
webui/react/src/utils/tests/generateTestData.ts 91.95% <ø> (-0.05%) ⬇️
...bui/react/src/components/ExperimentCreateModal.tsx 86.50% <75.00%> (+4.92%) ⬆️
...i/react/src/components/ExperimentContinueModal.tsx 68.40% <81.81%> (+4.82%) ⬆️
...ages/ExperimentDetails/ExperimentDetailsHeader.tsx 74.32% <60.00%> (ø)

... and 310 files with indirect coverage changes

@gt2345 gt2345 changed the title Gt/525 remove max length chore: Remove max_length from WebUI Oct 9, 2024
@gt2345 gt2345 changed the base branch from main to searcher-context-removal October 10, 2024 16:08
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci determined-ci requested a review from a team October 11, 2024 19:56
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 11, 2024
@rb-determined-ai rb-determined-ai force-pushed the searcher-context-removal branch 9 times, most recently from 46c2de8 to 4288a2e Compare October 25, 2024 19:11
@azhou-determined azhou-determined force-pushed the searcher-context-removal branch from 8d2a952 to 44dc56e Compare October 25, 2024 23:46
Base automatically changed from searcher-context-removal to main October 26, 2024 01:22
@mackrorysd
Copy link
Member

@gt2345 Can this be closed? I'm guessing it got incorporated into a larger PR.

@gt2345 gt2345 closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants