Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional APIs to support "actual select all" functions [ET-238] #10102

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented Oct 23, 2024

Ticket

Supports ET-238 with resources we missed in planning

Description

Fixes a couple bugs in bulk KillSearches, adds CancelSearches and LaunchTensorboardSearches

Test Plan

With the rest of ET-238, user should be able to select all searches matching a filter in the Web UI with a "true select all button", then perform bulk actions including "cancel" and "launch Tensorboard" and have them apply to all searches that match the filter even if they are not displayed on the current page view.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@jesse-amano-hpe jesse-amano-hpe requested a review from a team as a code owner October 23, 2024 03:04
@cla-bot cla-bot bot added the cla-signed label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 69.44444% with 33 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (22ad457) to head (f22e852).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
master/internal/api_searches.go 69.44% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10102      +/-   ##
==========================================
+ Coverage   54.49%   54.54%   +0.04%     
==========================================
  Files        1267     1267              
  Lines      159437   159499      +62     
  Branches     3637     3636       -1     
==========================================
+ Hits        86885    86997     +112     
+ Misses      72419    72369      -50     
  Partials      133      133              
Flag Coverage Δ
backend 45.88% <69.44%> (+0.15%) ⬆️
harness 72.55% <ø> (ø)
web 54.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/api_searches.go 78.12% <69.44%> (+23.23%) ⬆️

... and 8 files with indirect coverage changes

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f22e852
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67196ca037399b0008397924

Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the assist!

@jesse-amano-hpe jesse-amano-hpe merged commit deb3772 into main Oct 24, 2024
81 of 94 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the jta/search-api-open-tensorboard-cancel branch October 24, 2024 01:01
hkang1 added a commit that referenced this pull request Nov 18, 2024
hkang1 added a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants