-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional APIs to support "actual select all" functions [ET-238] #10102
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10102 +/- ##
==========================================
+ Coverage 54.49% 54.54% +0.04%
==========================================
Files 1267 1267
Lines 159437 159499 +62
Branches 3637 3636 -1
==========================================
+ Hits 86885 86997 +112
+ Misses 72419 72369 -50
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the assist!
Ticket
Supports ET-238 with resources we missed in planning
Description
Fixes a couple bugs in bulk
KillSearches
, addsCancelSearches
andLaunchTensorboardSearches
Test Plan
With the rest of ET-238, user should be able to select all searches matching a filter in the Web UI with a "true select all button", then perform bulk actions including "cancel" and "launch Tensorboard" and have them apply to all searches that match the filter even if they are not displayed on the current page view.
Checklist
docs/release-notes/
See Release Note for details.