Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ci postgres version from 10 -> 14 & parameterize all CI devcluster scripts on postgres version #10106

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

corban-beaird
Copy link
Contributor

@corban-beaird corban-beaird commented Oct 23, 2024

Ticket

Leaving this as a draft PR because I haven't had a chance to confirm that CI remains green after the upgrade & there's no tests that break when changing fro 10 -> 14

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 92ba6f7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/671c376957d0bb000841c6dd

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.14%. Comparing base (d943d85) to head (92ba6f7).
Report is 137 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10106      +/-   ##
==========================================
+ Coverage   54.51%   59.14%   +4.62%     
==========================================
  Files        1252      752     -500     
  Lines      156687   104552   -52135     
  Branches     3600     3599       -1     
==========================================
- Hits        85423    61833   -23590     
+ Misses      71131    42586   -28545     
  Partials      133      133              
Flag Coverage Δ
backend 43.80% <ø> (-1.40%) ⬇️
harness 72.74% <ø> (ø)
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 500 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants