Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update postgres aurora info #10116

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

tara-hpe
Copy link
Contributor

Update instances of "postgresql <14", add note about Aurora v1

@cla-bot cla-bot bot added the cla-signed label Oct 23, 2024
@tara-hpe tara-hpe requested a review from ioga October 23, 2024 23:52
@determined-ci determined-ci requested a review from a team October 23, 2024 23:52
@tara-hpe tara-hpe requested review from rb-determined-ai and removed request for a team October 23, 2024 23:52
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 23, 2024
@tara-hpe tara-hpe requested a review from maxrussell October 23, 2024 23:52
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4cea3db
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/671a95a9b88c2e0008668fe1

Copy link
Contributor

@rb-determined-ai rb-determined-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to @stoksc, and it sounds like our official stance is that we support any non-EOL version of postgres.

So it is ok to say we recommend version 14 or later, but we can't say you need version 14 or later.

Personally, I think support EOL software is never implied, and we can mostly just say "Install Postgres" everywhere and people should know that EOL postgres isn't gonna work.

If you want to specify that we don't support non-EOL postgres, I'd do it only once, maybe in the setup-cluster/checklists/postgresql.rst file, or a file of equal specificity.

I would not tell users they should install postgresql-14 on debian, for instance; I think they should take whatever postgresql version is default for their linux installation (the unmarked postgresql package).

Does that all make sense?

@ioga
Copy link
Contributor

ioga commented Oct 24, 2024

Personally, I think support EOL software is never implied, and we can mostly just say "Install Postgres" everywhere and people should know that EOL postgres isn't gonna work.

I'd suggest we specify the minimum required version, since there's a slice of customers who run older systems, and CEs always end up asking us what's the minimum. Especially here where we know 12 is the minimum.

@stoksc
Copy link
Contributor

stoksc commented Oct 24, 2024

We should at least say the minimum here still.

@stoksc
Copy link
Contributor

stoksc commented Oct 24, 2024

Elsewhere I'd just recommend the newest Postgres version available.

@tara-hpe tara-hpe force-pushed the docs/Update-postgres-aurora-info branch from 9db1110 to 2719ca5 Compare October 24, 2024 17:44
@determined-ci determined-ci requested a review from a team October 24, 2024 17:44
Update instances of "postgresql <14", add note about Aurora v1
@tara-hpe tara-hpe force-pushed the docs/Update-postgres-aurora-info branch from 965d539 to 0eec942 Compare October 24, 2024 18:02
@tara-hpe
Copy link
Contributor Author

We should at least say the minimum here still.

Keeping "The solution requires PostgreSQL 14 or later, which will be installed on the admin node." in hpc-environment-requirements.rst file

@tara-hpe tara-hpe force-pushed the docs/Update-postgres-aurora-info branch from 0eec942 to 40dbcfd Compare October 24, 2024 18:21
@tara-hpe tara-hpe force-pushed the docs/Update-postgres-aurora-info branch from 40dbcfd to 4cea3db Compare October 24, 2024 18:44
@determined-ci determined-ci requested a review from a team October 24, 2024 18:45
@tara-hpe tara-hpe enabled auto-merge (squash) October 24, 2024 18:45
@tara-hpe tara-hpe disabled auto-merge October 24, 2024 18:50
@tara-hpe tara-hpe merged commit 6158ef7 into main Oct 24, 2024
68 of 86 checks passed
@tara-hpe tara-hpe deleted the docs/Update-postgres-aurora-info branch October 24, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants