-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: known issue of tb_plugin #10178
Conversation
✅ Deploy Preview for determined-ui canceled.
|
- PyTorch has `deprecated | ||
<https://pytorch.org/tutorials/intermediate/tensorboard_profiler_tutorial.html#use-tensorboard-to-view-results-and-analyze-model-performance>` | ||
their Profiler TensorBoard Plugin. Our latest environment image comes with PyTorch 2.3, so some | ||
of the tb_plugin features may not work. If you are looking to use all the features, we suggest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would put tb_plugin in double backticks, ``tb_plugin``
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for finding this bug and seeing it through 🔥
(cherry picked from commit 5e1f492)
<https://pytorch.org/tutorials/intermediate/tensorboard_profiler_tutorial.html#use-tensorboard-to-view-results-and-analyze-model-performance>` | ||
their Profiler TensorBoard Plugin (``tb_plugin``), so some features may not be compatible with | ||
PyTorch 2.0 and above. Our current default environment image comes with PyTorch 2.3. If users | ||
experiencing issues with this plugin, we suggest using an image with PyTorch version earilier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
earilier -> earlier, if we get a chance to revise this before release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Revised: #10183
Ticket
Description
Pytorch Profiler TensorBoard Plugin is not compatible with our latest environment image, because it has been deprecated by PyTorch. Add it to the known issue.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.