Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: known issue of tb_plugin #10178

Merged
merged 4 commits into from
Oct 31, 2024
Merged

docs: known issue of tb_plugin #10178

merged 4 commits into from
Oct 31, 2024

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Oct 31, 2024

Ticket

Description

Pytorch Profiler TensorBoard Plugin is not compatible with our latest environment image, because it has been deprecated by PyTorch. Add it to the known issue.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 31, 2024
@determined-ci determined-ci requested a review from a team October 31, 2024 20:23
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 48c67c8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6723f6c2febeb80008e9119d

- PyTorch has `deprecated
<https://pytorch.org/tutorials/intermediate/tensorboard_profiler_tutorial.html#use-tensorboard-to-view-results-and-analyze-model-performance>`
their Profiler TensorBoard Plugin. Our latest environment image comes with PyTorch 2.3, so some
of the tb_plugin features may not work. If you are looking to use all the features, we suggest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would put tb_plugin in double backticks, ``tb_plugin``

Copy link
Contributor

@azhou-determined azhou-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for finding this bug and seeing it through 🔥

@jgongd jgongd changed the title Docs: known issue of tb_plugin docs: known issue of tb_plugin Oct 31, 2024
@jgongd jgongd merged commit 5e1f492 into main Oct 31, 2024
78 of 91 checks passed
@jgongd jgongd deleted the jgong/docs-pt-tb-plugin branch October 31, 2024 21:44
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
@jgongd jgongd mentioned this pull request Oct 31, 2024
5 tasks
<https://pytorch.org/tutorials/intermediate/tensorboard_profiler_tutorial.html#use-tensorboard-to-view-results-and-analyze-model-performance>`
their Profiler TensorBoard Plugin (``tb_plugin``), so some features may not be compatible with
PyTorch 2.0 and above. Our current default environment image comes with PyTorch 2.3. If users
experiencing issues with this plugin, we suggest using an image with PyTorch version earilier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

earilier -> earlier, if we get a chance to revise this before release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Revised: #10183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-0.38.0 cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants