feat: update the regex to match the new build output format #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
ioga
reviewed
Mar 7, 2023
julian-determined-ai
requested changes
Mar 10, 2023
There was a problem hiding this comment.
I would expect to see a Response Header of Cache-Control: public, max-age=31536000 for the following files based on this change which I do not see currently.
Please let me know if you are seeing something different or there is something I am missing.
(screenshot showing no response headers)
thiagodallacqua-hpe
force-pushed
the
thiago/WEB-953
branch
from
4144dc2
to
67b8345
Compare
thiagodallacqua-hpe
force-pushed
the
thiago/WEB-953
branch
from
67b8345
to
58f4038
Compare
julian-determined-ai
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
LGTM ✅ I am also going to note that non static assets are no longer being compressed for a similar reason, I made a ticket to fix the compression logic also: https://determinedai.atlassian.net/browse/WEB-1032
rb-determined-ai
pushed a commit
to rb-determined-ai/determined
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After we have migrated to
vite(#5926) our build output is different, and we're now splitting thevendorchunk from the rest of the compiled assets for long-term cache.This PR intends to update the regex for the HTTP cache to work with this new output.
Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket