Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use before/after search params for historic allocation CSV download endpoint [DET-10442] #9730

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

corban-beaird
Copy link
Contributor

@corban-beaird corban-beaird commented Jul 25, 2024

Ticket

DET-10442

Description

Due to a recent refactor, after & after timestamps were converted into from & to. This is fine for displaying the historic usage charts, which was the intended behavior; however, this was also applied to the logic for the historic allocation CSV request, which this PR returns to the original state.

Test Plan

  • Ensure that historic allocation CSV download (both Group By: Workloads & Allocations) successfully starts a download for the provided time range in the webUI

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@corban-beaird corban-beaird requested a review from a team as a code owner July 25, 2024 19:44
@corban-beaird corban-beaird requested a review from ashtonG July 25, 2024 19:44
@cla-bot cla-bot bot added the cla-signed label Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 48e56ec
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a2ab233dc334000874e19a
😎 Deploy Preview https://deploy-preview-9730--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@corban-beaird corban-beaird added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.82%. Comparing base (a32b010) to head (48e56ec).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9730      +/-   ##
==========================================
- Coverage   53.35%   48.82%   -4.53%     
==========================================
  Files        1257      934     -323     
  Lines      154493   125191   -29302     
  Branches     3299     3300       +1     
==========================================
- Hits        82427    61127   -21300     
+ Misses      71916    63914    -8002     
  Partials      150      150              
Flag Coverage Δ
harness ?
web 51.72% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...luster/ClusterHistoricalUsageCsvModalComponent.tsx 0.00% <0.00%> (ø)

... and 323 files with indirect coverage changes

@corban-beaird
Copy link
Contributor Author

Merging despite CI failures, they're the result of unrelated flakes

@corban-beaird corban-beaird merged commit d46d776 into main Jul 25, 2024
88 of 105 checks passed
@corban-beaird corban-beaird deleted the corban/historic-allocation-csv-field-fix branch July 25, 2024 20:41
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants