fix: use different modules for Trial and Cluster topology #9917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gt2345
reviewed
Sep 11, 2024
| import Section from 'components/Section'; | ||
| import { Agent, Resource, SlotsRecord } from 'types'; | ||
|
|
||
| import css from './Topology.module.scss'; |
There was a problem hiding this comment.
We need to restore the previous css file, too
There was a problem hiding this comment.
oops, thanks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9917 +/- ##
==========================================
- Coverage 59.23% 54.08% -5.16%
==========================================
Files 750 442 -308
Lines 104343 75821 -28522
Branches 3598 3598
==========================================
- Hits 61812 41009 -20803
+ Misses 42400 34680 -7720
- Partials 131 132 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://hpe-aiatscale.atlassian.net/browse/CM-517
Description
when we introduced trial detail topology, we use the same module, but for cluster topology we want to preserve the individual slot data.
Test Plan
Checklist
docs/release-notes/See Release Note for details.