feat: add e2e tests for multi-sort filter on experiments lista #9992
+159
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thiagodallacqua-hpe
changed the title
thiagodallacqua-hpe
requested review from
ashtonG,
JComins000 and
johnkim-det
JComins000
reviewed
Sep 25, 2024
JComins000
reviewed
Sep 25, 2024
JComins000
reviewed
Sep 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9992 +/- ##
==========================================
- Coverage 59.17% 50.56% -8.62%
==========================================
Files 755 949 +194
Lines 104932 128621 +23689
Branches 3615 3616 +1
==========================================
+ Hits 62098 65039 +2941
- Misses 42701 63449 +20748
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
JComins000
reviewed
Sep 25, 2024
JComins000
approved these changes
Sep 25, 2024
thiagodallacqua-hpe
requested review from
JComins000 and
a team
and removed request for
gt2345
ashtonG
requested changes
Sep 26, 2024
There was a problem hiding this comment.
This test isn't testing the sort order. The sort settings aren't used in the cli call that you're using. You can also tell that the test isn't properly testing by swapping the checkTableOrder calls.
Please test that the sort order is being applied and working in the frontend.
- ensure that you're picking columns that can be tested. Because we're using the same config for all the experiments in this project, sorting on trial count and searcher will not affect the sort order.
- check the status of the search in the dom. you can do this by checking that the column values are in the order that you expect them to be and/or ensuring that the call to
experiments-searchwas made with the parameters you expect. Obviously given the context the former would be better than the latter.
thiagodallacqua-hpe
force-pushed
the
jcom/TESTENG-100/nth-bugfix
branch
from
387f6a2
to
350796f
Compare
JComins000
force-pushed
the
jcom/TESTENG-100/nth-bugfix
branch
from
350796f
to
387f6a2
Compare
thiagodallacqua-hpe
force-pushed
the
jcom/TESTENG-100/nth-bugfix
branch
from
387f6a2
to
c7918e0
Compare
…experimentList.spec.ts
Refactor the getColumnTextValue function in experimentList.spec.ts to simplify the code and improve readability. Update function calls to reflect changes in the function implementation.
ashtonG
reviewed
Sep 30, 2024
Co-authored-by: Ashton G. <ashton.galloway@hpe.com>
thiagodallacqua-hpe
force-pushed
the
jcom/TESTENG-100/nth-bugfix
branch
from
1f56b90
to
6e2b1a8
Compare
|
after the last changes, my local are still passing, so, let's see how the CI env will handle 😅
cc @ashtonG |
thiagodallacqua-hpe
force-pushed
the
jcom/TESTENG-100/nth-bugfix
branch
from
cae358d
to
f072890
Compare
|
the current state of local after the last changes:
|
ashtonG
reviewed
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-752
Description
This PR intends to add e2e tests for the multi-sort filter for the experiment list.
Test Plan
run the test
'Multi-sort menu'test scripts on playwrite.Checklist
docs/release-notes/See Release Note for details.