test: add e2e experiment list pagination test #9993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a pagination test to the e2e experiment list test suite. We check page url parameter after interacting with the pagination element. Because the table rows are virtualized, we cannot directly check the row count based on what is in the html dom.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9993 +/- ##
==========================================
- Coverage 54.53% 50.47% -4.06%
==========================================
Files 1257 948 -309
Lines 156935 128341 -28594
Branches 3614 3613 -1
==========================================
- Hits 85578 64776 -20802
+ Misses 71224 63432 -7792
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ashtonG
commented
Sep 25, 2024
JComins000
reviewed
Sep 25, 2024
| @@ -109,6 +109,14 @@ test.describe('Experiment List', () => { | |||
| await tableFilter.close(); | |||
| await waitTableStable(); | |||
| }); | |||
| await test.step('Ensure pagination options', async () => { | |||
JComins000
reviewed
Sep 25, 2024
| return res.url().endsWith('experiments-search'); | ||
| }); | ||
| const params = new URL(projectDetailsPage._page.url()).searchParams; | ||
| expect(params.get('page')).toBe(pageParam); |
JComins000
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-754
Description
This adds a pagination test to the e2e experiment list test suite. We check page url parameter after interacting with the pagination element. Because the table rows are virtualized, we cannot directly check the row count based on what is in the html dom.
Test Plan
React-e2e tests should pass
Checklist
docs/release-notes/See Release Note for details.