Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Workspace Models tests [CM-538] #9998

Merged
merged 11 commits into from
Oct 8, 2024
Merged

test: Workspace Models tests [CM-538] #9998

merged 11 commits into from
Oct 8, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Sep 27, 2024

Ticket

CM-538

Description

Adds automated e2e tests for "Workspace Models" section of Workspaces/Projects release party test plan

https://hpe-aiatscale.atlassian.net/wiki/spaces/ENGINEERIN/pages/1321238531/Workspaces+Projects

Test Plan

No additional testing required, automated tests should pass.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit baa91b7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66fab5cc8d4663000883dea2
😎 Deploy Preview https://deploy-preview-9998--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

selector: '[id="modelDescription"]',
});
readonly addMoreDetails = new BaseComponent({
parent: this,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.body?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as well as the others

Copy link
Contributor

@JComins000 JComins000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly im just excited to see all my work being expanded upon. thanks for the contributions, very nice pace as well.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 50.47%. Comparing base (bc3b2a6) to head (baa91b7).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/components/ModelRegistry.tsx 0.00% 7 Missing ⚠️
webui/react/src/components/ModelMoveModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9998      +/-   ##
==========================================
- Coverage   54.53%   50.47%   -4.06%     
==========================================
  Files        1257      948     -309     
  Lines      156933   128347   -28586     
  Branches     3614     3614              
==========================================
- Hits        85587    64787   -20800     
+ Misses      71213    63427    -7786     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.34% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/components/ModelCreateModal.tsx 76.89% <100.00%> (+0.16%) ⬆️
webui/react/src/components/ModelMoveModal.tsx 0.00% <0.00%> (ø)
webui/react/src/components/ModelRegistry.tsx 0.00% <0.00%> (ø)

... and 309 files with indirect coverage changes

Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example for unit tests!
Do we think it's possible to auto generate boiler plate code such as ModelCreateModal

@johnkim-det johnkim-det merged commit 33dfdaf into main Oct 8, 2024
82 of 94 checks passed
@johnkim-det johnkim-det deleted the CM-538 branch October 8, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants