Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gpt-neox image to gpt-neox v2.0 and combine with gpt-neox build #205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update gpt-neox image to gpt-neox v2.0 and combine with gpt-neox build #205

wants to merge 1 commit into from

Conversation

liamcli
Copy link
Contributor

@liamcli liamcli commented Apr 27, 2023 •
edited
Loading

Description

Making a few changes to how we build the deepspeed image for GPT-NeoX.

  • We previously had a separate Dockerfile to install gpt-neox into the gpt-neox deepspeed image built here. This is now combined into one script within install_deepspeed.sh that will do further installation for gpt-neox if the deepspeed git passed is the Eleuther AI fork.
  • Updating to GPT-NeoX v2 when previously we were on v1

Checklist

  • Bump VERSION to make the pushed images are tagged with the right version.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 27, 2023
@liamcli liamcli mentioned this pull request May 2, 2023
Closed
@liamcli liamcli requested a review from mpkouznetsov May 16, 2023 22:37
@liamcli
Copy link
Contributor Author

liamcli commented May 16, 2023

Two flows to build deepspeed and gpt-neox images succeeded in circleci: https://app.circleci.com/pipelines/github/determined-ai/environments?branch=gpt-neox2

mpkouznetsov
mpkouznetsov approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@mpkouznetsov mpkouznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpkouznetsov mpkouznetsov mpkouznetsov approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@mpkouznetsov mpkouznetsov

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamcli @mpkouznetsov