Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethers v6 target #808

Merged
merged 33 commits into from
Feb 21, 2023
Merged

Ethers v6 target #808

merged 33 commits into from
Feb 21, 2023

Conversation

krzkaczor
Copy link
Member

zemse and others added 30 commits January 3, 2023 07:18
@zemse
Duplicate ethers-v5 for creating v6 target
d6a6c6c
@zemse
Change v5 to v6
911d6d3
@zemse
Register new target in workspace
acd66ef
@zemse
Update typescript version
92c71c2
@zemse
Add draft changes to make the types work
5d1013e
@zemse
First pass on type check
1eb0015
@zemse
Generate types
83b4ecc
@zemse
Fix tests
e90ce28
@zemse
Install latest ethers v6
c51b26c
@zemse
Fix event tests
8997e10
@zemse
Resolve todo comments
2a1c15b
@zemse
Fix filter input arguments type
c2435cb
@zemse
Display label in tuples
4369840
@zemse
Fix tests
17c4dd0
@zemse
Add ethers-v6 example
1984009
@zemse
Fix typecheck
10263a3
@zemse
Set moduleResolution as node16 for ethers-v6
54768ba 
This is because ethers internally imports @adraffy/ens-normalize/xnf
which gives typecheck error if not using node16 module resolution. The
potential issue of using node16 is that common js imports stop working
for a dependency that has exports field defined in it's package json.
@zemse
Remove PromiseOrValue
aa3a360
@zemse
Update ethers version
b34528a
@zemse
Remove unused type
bc78786
@zemse
Use AddressLike for addresses
e129484
@zemse
Fix issues
09704a5
@zemse
Update types
29819d4
@zemse
Add changeset
1223b9f
@zemse
Fix failing test
eb41a9c
@zemse
Commit local changes after running tests
8822317
@zemse
Update target version in example
e1aa77c
@zemse
Relax ethers peer dependency version
0095d4d
@zemse
Update readme
0770179
@krzkaczor
Merge branch 'master' into ethers-v6-target
005833b 
# Conflicts:
#	package.json
#	pnpm-lock.yaml
@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 8fd44a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@typechain/ethers-v6 Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@krzkaczor krzkaczor mentioned this pull request Feb 21, 2023
Closed
@krzkaczor krzkaczor merged commit 3eb246b into master Feb 21, 2023
@krzkaczor krzkaczor deleted the ethers-v6-target branch February 21, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzkaczor @zemse