Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #886
The ethers v6
reservedKeywords
set was quite outdated. It had ethers v5 contract property names that no longer exist for v6 contracts (e.g.:provider
) and was missing some v6 contract property names (e.g.:target
). Rather than attempting to manually keep thereservedKeywords
list up-to-date, I'd propose to directly read the list of built-in properties from the BaseContract class.The
then
property is a peculiar case. It's not a property of BaseContract, but still won't be passed through by ethers as it is kept in a specialpassProperties
list (see: ethers v6 BaseContract Proxy).