-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gl: Relax GLSL requirement from 3.3 to 3.1 #137
gl: Relax GLSL requirement from 3.3 to 3.1 #137
Conversation
With these changes, it is possible to start dethrace on Pinebook Pro (Mali-T860 / Panfrost): OpenGL vendor string: Panfrost OpenGL renderer string: Mali-T860 (Panfrost) OpenGL core profile version string: 3.1 Mesa 22.3.0-devel (git-d08bd9a8d8) OpenGL core profile shading language version string: 1.40
4ee3cb6
to
d7055bc
Compare
thanks! Your core profile reported in your output is Just curious, trying to understand the various OpenGL version conventions! |
After changing the version to 3.1, it built, but failed to compile shaders runtime:
And after fixing the shaders (I eventually settled to lowest possible requirements), it crashed because due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to keep the core profile active since I'm on a Mac and without the core profile it falls back to OpenGL 2.1.
I suggested some changes to the PR that still work on my machine and should work on yours too, in theory!
The change from glFrameBufferTexture
to glFrameBufferTexture2D
is fine, I actually made the same change myself in a different branch
@plaes when you have a minute, could you help validate the suggested changes? thanks! |
cf07a08
to
a6daa80
Compare
Pushed the changes and validated they work too. |
thanks very much! |
@plaes could you take a quick photo of it running on your pinebook? I'd love to throw it up on our twitter feed :) |
With these changes, it is possible to start dethrace on
Pinebook Pro (Mali-T860 / Panfrost):