Re-enables back face culling #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madebr
approved these changes
Oct 26, 2022
|
Yep, its win-win 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of #187 is weird track geometry where two back-facing triangles with no texture are laid on top of two front-facing textured triangles. The OG game culls the back-facing triangle, so it is not visible in game. (Ref: https://twitter.com/toshiba_3/status/1584152161386389504?s=20&t=g1bQ8KAAtKvn2zy1Qw6PUw)
As we are not culling, we render the back facing triangles, which causes the appearance of a missing texture in that part of the track!
We originally removed culling because it caused sides of streetlight poles to be invisible when viewed from the rear. Since then, we fixed/implemented
RemoveDoubleSidedwhich causes every face with aBR_MATF_TWO_SIDEDmaterial to be duplicated and faced backwards. We can now cull back faces without any apparent graphical issues.Fixes: #187